Bump the namespace-actions group with 2 updates - #1
Closed
dependabot[bot] wants to merge 1 commit into
Closed
Conversation
Bumps the namespace-actions group with 2 updates: [namespacelabs/nscloud-checkout-action](https://github.com/namespacelabs/nscloud-checkout-action) and [namespacelabs/nscloud-cache-action](https://github.com/namespacelabs/nscloud-cache-action). Updates `namespacelabs/nscloud-checkout-action` from 8.1.1 to 8.1.2 - [Release notes](https://github.com/namespacelabs/nscloud-checkout-action/releases) - [Commits](namespacelabs/nscloud-checkout-action@938f5d2...6c0b4ec) Updates `namespacelabs/nscloud-cache-action` from 1.4.2 to 1.4.3 - [Release notes](https://github.com/namespacelabs/nscloud-cache-action/releases) - [Commits](namespacelabs/nscloud-cache-action@a90bb5d...15799a6) --- updated-dependencies: - dependency-name: namespacelabs/nscloud-checkout-action dependency-version: 8.1.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: namespace-actions - dependency-name: namespacelabs/nscloud-cache-action dependency-version: 1.4.3 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: namespace-actions ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
linuxhex
deleted the
dependabot/github_actions/namespace-actions-3107070926
branch
August 4, 2026 06:25
Contributor
Author
|
This pull request was built based on a group rule. Closing it will not ignore any of these versions in future pull requests. To ignore these dependencies, configure ignore rules in dependabot.yml |
linuxhex
added a commit
that referenced
this pull request
Aug 4, 2026
Closes #9196.
### Description
Two `show_code_review_button` gates were dropping panel-open requests on
the floor when the user had hidden the toolbar button:
**1. Data-path gate at `Workspace::setup_code_review_panel`
(`view.rs:7982`)**
```rust
if !*TabSettings::as_ref(ctx).show_code_review_button {
return;
}
```
`update_right_panel_open_state` calls into this whenever the right panel
is being opened (chip click, `Shift+Cmd+=` keybinding, etc.), so the
early return silently swallowed every explicit user action.
**2. Render-path gate at `Workspace::render_config_panel` and
`render_config_panel_maximized` (`view.rs:18981` / `19040`)**
```rust
if !item.is_available(app) || !item.is_panel() { return None; }
…
if !HeaderToolbarItemKind::CodeReview.is_available(app) { return None; }
```
`HeaderToolbarItemKind::is_available` for `CodeReview` returns
`*TabSettings::as_ref(app).show_code_review_button.value()`
(`header_toolbar_item.rs:89`). So even after fix #1 set
`pane_group.right_panel_open = true` and `setup_code_review_panel` ran,
the next render frame saw `is_available() == false` and returned `None`
— the `right_panel_view` was never added to the layout.
This second gate is what @moirahuang flagged when their local repro
still showed nothing happening after the first fix landed. The data was
correct; the panel was just never composed into the UI.
### Fix
1. **Drop the early return at `setup_code_review_panel`.** The setting
is meant to gate only the toolbar button's visibility (already enforced
correctly by `header_toolbar_item.rs::is_available`, which feeds
`render_header_toolbar_button` at `view.rs:17276`).
2. **Switch panel-render call sites from `is_available` →
`is_supported`.** `is_available`'s own doc-comment says it's
specifically *"Whether this item should be shown in the **toolbar** —
checks both `is_supported` and user show/hide preferences."* Using it to
gate panel rendering conflates two unrelated concerns. Panel rendering
should only care about whether the feature is compiled in
(`is_supported`), not whether the user has hidden the toolbar button.
For `CodeReview`, `is_supported` is `cfg!(feature = "local_fs")`. For
the other variants in the same match (`TabsPanel`, `ToolsPanel`),
`is_available` already equals `is_supported` (default `_ => true` arm in
the inner match), so behaviour is unchanged. `AgentManagement` and
`NotificationsMailbox` return `None` unconditionally inside
`render_config_panel`, so the change is moot for them too.
### Caller audit for `setup_code_review_panel`
5 call sites in `view.rs`:
1. `view.rs:3681` — `TransferredTab` flow, only runs when the source tab
already had `right_panel_open == true`.
2. `view.rs:8136` — `update_right_panel_open_state` with `should_open ==
true`. **The diff-button path** that #9196 is about.
3. `view.rs:13372` — `PaneFocused` event, gated on `right_panel_open`
already true.
4. `view.rs:13490` — `RepoChanged` event, gated on `right_panel_open`
already true.
5. `view.rs:14458` — session env update, gated on `right_panel_open`
already true.
None of these need the `show_code_review_button` gate — they're either
explicit user actions or gated on `right_panel_open` already being open.
The toolbar button toggle continues to do its job at
`render_header_toolbar_button` independently.
### Testing
Reproduced @moirahuang's test locally on macOS 26.4.1 (Apple Silicon)
against `WarpOss.app` built from this branch:
1. Settings → "Show code review button" → **OFF**
2. `echo "x" >> README.md` inside a git repo
3. Click the diff stats chip on the prompt (`+1 -0`)
**Result:** Code review panel opens on the right showing the diff, while
the toolbar button stays hidden — exactly the expected behaviour from
issue #9196. Inverse case (toggle ON) also verified: toolbar button
visible, panel still works the same.
- `cargo fmt -p warp -- --check` passes.
- `cargo nextest` skipped locally — Metal toolchain unavailable on my
machine, mirroring #9277. CI will exercise the change.
### Server API
No server changes.
### Agent Mode
Not applicable.
### Changelog Entries
`CHANGELOG-BUG-FIX`: The diff button on the terminal prompt now opens
the code review panel even when the toolbar's "Show code review button"
toggle is disabled (regression from a recent release).
Co-authored-by: anshul-garg27 <13553550+anshul-garg27@users.noreply.github.com>
linuxhex
added a commit
that referenced
this pull request
Aug 4, 2026
## Description The remote server daemon goes through the full `run_internal` → `initialize_app` → `launch` path before binding its Unix socket. The `IntervalTimer` records interval markers (`LOG_FILE_SETUP_COMPLETE`, `SQLITE_INITIALIZED`, `SINGLETON_MODELS_REGISTERED`, etc.) throughout this path, but the timing data was **never emitted** — `AppStartup` is only sent inside `ctx.on_first_frame_drawn()`, which never fires for headless processes like the daemon. This means we have zero visibility into whether daemon socket timeouts (the #1 remote server initialization error) are caused by slow cold starts, silent crashes, or NFS bind failures. **Changes:** - Add a `RemoteServerDaemonStartup` telemetry event that carries the same `IntervalTimer` timing data as `AppStartup` - Emit it from `launch_daemon` after the Unix socket is successfully bound, with a final `DAEMON_SOCKET_BOUND` interval marker - Telemetry sends directly to Rudderstack using the baked-in write key — no user auth token required ## Linked Issue - Part of remote server initialization error triage ## Testing - [x] `cargo fmt` passes - [x] `cargo clippy -p warp --all-targets --all-features --tests -- -D warnings` passes - Telemetry emission is on the existing `send_telemetry_from_app_ctx!` path used by all other remote server events — no new networking or auth code ## Agent Mode - [x] Warp Agent Mode - This PR was created via Warp's AI Agent Mode <!-- CHANGELOG-NONE -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the namespace-actions group with 2 updates: namespacelabs/nscloud-checkout-action and namespacelabs/nscloud-cache-action.
Updates
namespacelabs/nscloud-checkout-actionfrom 8.1.1 to 8.1.2Commits
6c0b4ecMerge pull request #41 from namespacelabs/feature-20260504-cancel-stalling-gi...f4ed837Add cancel-stalling-git-operations inputUpdates
namespacelabs/nscloud-cache-actionfrom 1.4.2 to 1.4.3Release notes
Sourced from namespacelabs/nscloud-cache-action's releases.
Commits
15799a6Bump typescript from 6.0.2 to 6.0.3 in the minor-npm-dependencies group (#126)a74ba09Add npm mode test (#118)3accca6Bump@eslint/jsfrom 9.39.2 to 10.0.1 (#102)320beceBump typescript from 5.9.3 to 6.0.2 (#120)7b579dfBump eslint from 9.39.4 to 10.2.0 (#121)0170534Bump the minor-actions-dependencies group with 3 updates (#122)04d1d76Bump the major-actions-dependencies group across 1 directory with 4 updates (...0496385Upgrade@namespacelabs/actions-toolkitto 0.3.0 (#125)e14531aAdd major-actions-dependencies Dependabot group (#119)1f34f97Bump the minor-npm-dependencies group across 1 directory with 6 updates (#116)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions