Skip to content

fix(vulnerabilities): coalesce summary and details for description field #3990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
epipav wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

fix(vulnerabilities): coalesce summary and details for description field #3990

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion services/libs/tinybird/pipes/vulnerabilities_list.pipe
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ SQL >
any (arrayElement(v.cveIds, 1)) as cveId,
any (v.packageName) as packageName,
any (v.severity) as severity,
any (v.summary) as description,
coalesce(any (v.summary), any (v.details)) as description,
Copy link
Copy Markdown

@cursor cursor bot Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

coalesce never falls back because column is non-nullable

High Severity

coalesce(any(v.summary), any(v.details)) will never fall back to v.details because the summary column is defined as a non-nullable String with DEFAULT '' in the datasource. The any() aggregate on a non-nullable string column returns '' (not NULL) when the value is empty, and coalesce only substitutes NULL values. The fallback is effectively dead code. Something like nullIf would be needed to convert empty strings to NULL before coalesce can work as intended.

Fix in Cursor Fix in Web

Copy link

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any() is non-deterministic across rows in the group. Using coalesce(any(v.summary), any(v.details)) can pick summary from one row and details from another, or fall back to details even when a non-null summary exists in a different row within the same (vulnerabilityId, packageName) group. To keep the coalescing per-row and then aggregate consistently, apply coalesce before the aggregate (e.g., aggregate any(coalesce(v.summary, v.details)) or an equivalent deterministic aggregate).

Suggested change
coalesce(any (v.summary), any (v.details)) as description,
any(coalesce(v.summary, v.details)) as description,

Copilot uses AI. Check for mistakes.
any (v.packageEcosystem) as ecosystem,
any (v.publishedAt) as publishedAt,
any (v.status) as status,
Expand Down
Loading