Skip to content

fix(settings): use combo box for photo format#507

Open
Resurgamz wants to merge 1 commit into
linuxdeepin:release/eaglefrom
Resurgamz:feature/fix-BUG156865
Open

fix(settings): use combo box for photo format#507
Resurgamz wants to merge 1 commit into
linuxdeepin:release/eaglefrom
Resurgamz:feature/fix-BUG156865

Conversation

@Resurgamz

@Resurgamz Resurgamz commented Jul 22, 2026

Copy link
Copy Markdown

Replace the read-only photo format label with the standard settings combo box.

The photo output format now exposes a single JPG option, keeping the control consistent with other output settings and allowing future formats to be added without another UI rewrite.

Remove the obsolete formatLabel widget registration, implementation, and accessibility identifier.

Validation: JSON syntax check, static reference check, and git diff --check.

Related: BUG-156865

Summary by Sourcery

Replace the photo format settings label with a standard combo box control and remove the obsolete label widget wiring.

New Features:

  • Expose the photo output format as a selectable settings combo box, initially offering a single JPG option.

Enhancements:

  • Remove the custom format label widget implementation and its registration from the settings dialog.
  • Drop the unused accessibility identifier for the photo format label from the accessibility definitions.

Replace the read-only photo format label with the standard settings combo box.

The photo output format now exposes a single JPG option, keeping the control consistent with other output settings and allowing future formats to be added without another UI rewrite.

Remove the obsolete formatLabel widget registration, implementation, and accessibility identifier.

Validation: JSON syntax check, static reference check, and git diff --check.

Related: BUG-156865
@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Resurgamz

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sourcery-ai

sourcery-ai Bot commented Jul 22, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Replaces the custom read-only photo format label widget with the standard settings combo box configuration, exposing a single JPG option and cleaning up obsolete widget registration and accessibility identifiers.

State diagram for photo format setting UI change

stateDiagram-v2
    state PhotoFormatSettingUI {
        ReadOnlyFormatLabel
        ComboBoxFormatOption
    }

    ReadOnlyFormatLabel --> ComboBoxFormatOption : settings_json_updated
Loading

File-Level Changes

Change Details Files
Remove the custom format label widget implementation and its factory registration, migrating the photo format setting to the standard combo box configuration.
  • Deleted the createFormatLabelOptionHandle helper that built a DLabel-based, read-only format display wrapped in a custom layout.
  • Removed registration of the "formatLabel" widget from the settings dialog widget factory.
  • Ensured the photo format setting is defined in settings.json as a combo box with a single JPG option, aligned with other output settings.
src/src/mainwindow.cpp
src/assets/resource/settings.json
Clean up obsolete accessibility identifiers tied to the removed format label widget.
  • Removed the OPTION_FORMAT_LABER accessibility define used by the deprecated format label widget.
  • Kept other accessibility identifiers intact for remaining settings controls.
src/src/accessibility/ac-deepin-camera-define.h

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants