Skip to content

fix: fix notification text being truncated after replace #1619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deepin-bot merged 1 commit into from
Jun 5, 2026
Merged

fix: fix notification text being truncated after replace #1619

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions panels/notification/bubble/bubblemodel.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,16 @@ BubbleItem *BubbleModel::replaceBubble(BubbleItem *bubble)
Q_ASSERT(isReplaceBubble(bubble));
const auto replaceIndex = replaceBubbleIndex(bubble);
const auto oldBubble = m_bubbles[replaceIndex];
m_bubbles.replace(replaceIndex, bubble);
Q_EMIT dataChanged(index(replaceIndex), index(replaceIndex));

// Use remove + insert instead of dataChanged to force the view
// to recreate the delegate, so ListView recalculates its height.
beginRemoveRows(QModelIndex(), replaceIndex, replaceIndex);
m_bubbles.removeAt(replaceIndex);
endRemoveRows();

beginInsertRows(QModelIndex(), replaceIndex, replaceIndex);
m_bubbles.insert(replaceIndex, bubble);
endInsertRows();

return oldBubble;
}
Expand Down
Loading