fix: handle empty icon name in notification item#1193
Merged
Conversation
1. Modified DciIcon name property to use a fallback value when iconName is empty 2. Added default icon "application-x-desktop" to prevent missing icon display 3. Ensures notifications always show an appropriate icon even when none is specified fix: 处理通知项中图标名称为空的情况 1. 修改 DciIcon 的 name 属性,在 iconName 为空时使用回退值 2. 添加默认图标 "application-x-desktop" 防止图标缺失显示 3. 确保即使未指定图标时通知也能显示适当的图标 pms: BUG-311315
18202781743
requested review from
BLumia,
fly602,
mhduiy,
robertkill and
yixinshark
July 17, 2025 07:19
deepin pr auto review关键摘要:
是否建议立即修改:
|
Reviewer's GuideAdds conditional logic to DciIcon name binding, defaulting to “application-x-desktop” when iconName is empty to ensure notifications always display an icon. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @18202781743 - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
mhduiy
approved these changes
Jul 17, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
is empty
display
is specified
fix: 处理通知项中图标名称为空的情况
pms: BUG-311315
Summary by Sourcery
Bug Fixes: