Skip to content

fix(hotspot): reduce my hotspot title font weight to match shared settings#584

Open
iCancely wants to merge 1 commit into
linuxdeepin:masterfrom
iCancely:fix/hotspot-title-font-weight
Open

fix(hotspot): reduce my hotspot title font weight to match shared settings#584
iCancely wants to merge 1 commit into
linuxdeepin:masterfrom
iCancely:fix/hotspot-title-font-weight

Conversation

@iCancely

Copy link
Copy Markdown

问题

网络模块-个人热点页面,"我的热点"大标题字体过粗。

修改

dcc-network/qml/PageHotspot.qml 中"我的热点"标题 Label 的字体 weight 从 700 改为 500,与下方"共享设置"使用的默认 DccTitleObject 粗细保持一致。

PMS: BUG-371463

…tings

1. Change the My Hotspot title label font weight from 700 to 500
2. Align the title weight with the default DccTitleObject used by Shared Settings below

Log: Reduce My Hotspot title font weight to match Shared Settings title
Influence: Hotspot page title no longer appears overly bold

fix(hotspot): 减小我的热点标题字重以与共享设置一致

1. 将"我的热点"标题标签字重从 700 改为 500
2. 使标题字重与下方"共享设置"使用的默认 DccTitleObject 保持一致

Log: 减小我的热点标题字重以与共享设置标题一致
PMS: BUG-371463
Influence: 热点页面标题不再过粗

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @iCancely, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

★ 总体评分:95分

■ 【总体评价】

代码正确修复了UI字体粗细不符合设计规范的问题,将字体Weight从700调整为500。
逻辑正确,无安全漏洞,符合UOS设计规范,扣分极少仅因缺乏上下文注释。

■ 【详细分析】

  • 1.语法逻辑(完全正确)✓

代码在dcc-network/qml/PageHotspot.qml中修改了DccUtils.copyFont的传入参数,将字典中的"weight"键对应的值从700修改为500,语法完全正确。
潜在问题:无
建议:无需修改

  • 2.代码质量(良好)✓

修改直接且符合UOS的UI设计规范,将过粗的Bold(700)降级为Medium(500),提升了界面的视觉一致性。
潜在问题:硬编码的字体粗细数值(如500)散落在QML文件中,后续若规范变更可能需要多处修改。
建议:可以考虑在D.DTK.fontManager或全局工具类中定义好对应规范的字体对象,避免在业务QML中硬编码weight数值。

  • 3.代码性能(无性能问题)✓

仅修改了字体的属性参数,不涉及任何算法复杂度、循环或资源分配的变化,对性能无影响。
潜在问题:无
建议:无需修改

  • 4.代码安全(存在0个安全漏洞)✓

漏洞对比统计:新增漏洞 0 个,减少漏洞 0 个,持平 0 个
本次代码修改仅涉及UI样式的数值调整,不存在任何外部输入处理、文件操作或网络请求,不存在安全风险。

  • 建议:无需修复

■ 【改进建议代码示例】

// 建议如果项目中有统一管理字体的机制,可直接引用预设字体,避免硬编码
page: RowLayout {
    Label {
        // 假设 fontManager 中有符合规范的 medium t5 字体
        font: D.DTK.fontManager.t5_medium 
        text: dccObj.displayName
        Layout.alignment: Qt.AlignLeft

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, iCancely

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants