Skip to content

fix: section sort no longer works#785

Merged
BLumia merged 1 commit into
linuxdeepin:masterfrom
BLumia:amend-6b0ee24
Jul 23, 2026
Merged

fix: section sort no longer works#785
BLumia merged 1 commit into
linuxdeepin:masterfrom
BLumia:amend-6b0ee24

Conversation

@BLumia

@BLumia BLumia commented Jul 23, 2026

Copy link
Copy Markdown
Member

修正分组排序的顺序不再正确的问题.

@BLumia
BLumia requested a review from Ivy233 July 23, 2026 02:16

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @BLumia, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

修正分组排序的顺序不再正确的问题.

Log:
@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

★ 总体评分:95分

■ 【总体评价】

代码有效修复了Qt6下排序失效的问题,逻辑清晰且注释详尽,无安全漏洞。
逻辑正确且性能优化合理,仅因版权年份更新等微小瑕疵扣5分。

■ 【详细分析】

  • 1.语法逻辑(完全正确)✓

修改了setCategoryType函数,使用sort(0)替代setDynamicSortFilter(true),正确设置了proxy_sort_column,解决了Qt6下不排序的问题。新增了sectionRoleName属性并在排序后更新,确保QML端获取正确的分组属性。
潜在问题:无
建议:无

  • 2.代码质量(优秀)✓

注释非常详尽,准确解释了Qt6内部机制和修改原因。新增了sectionRoleName属性,保持了良好的封装性。版权信息更新为2023 - 2026。
潜在问题:无
建议:无

  • 3.代码性能(良好)✓

使用sort(0)触发的layoutAboutToBeChanged/layoutChanged信号代替了可能引发modelReset的操作,避免了QML视图代理的销毁和重建,提升了UI刷新性能。
潜在问题:无
建议:无

  • 4.代码安全(存在0个安全漏洞)✓

漏洞对比统计:新增漏洞 0 个,减少漏洞 0 个,持平 0 个
本次代码修改仅涉及模型排序逻辑和属性暴露,不涉及外部输入处理、网络请求或系统命令执行,不存在安全风险。

  • 建议:无

■ 【改进建议代码示例】

// 当前代码已经足够优秀,无需进一步修改。
// 以下为原修复代码片段展示:
sort(0);
setDynamicSortFilter(wasDynamic);

m_sectionRoleName = sortRoleName();
emit sectionRoleNameChanged();

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, Ivy233

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BLumia
BLumia merged commit e4669b8 into linuxdeepin:master Jul 23, 2026
9 checks passed
@BLumia
BLumia deleted the amend-6b0ee24 branch July 23, 2026 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants