Skip to content

chore: bump version 6.0.9#391

Merged
justforlxz merged 1 commit into
linuxdeepin:masterfrom
justforlxz:master
May 18, 2026
Merged

chore: bump version 6.0.9#391
justforlxz merged 1 commit into
linuxdeepin:masterfrom
justforlxz:master

Conversation

@justforlxz

@justforlxz justforlxz commented May 15, 2026

Copy link
Copy Markdown
Member
  • bump version to 6.0.9

Log : bump version to 6.0.9

Summary by Sourcery

Chores:

  • Update package metadata to reflect version 6.0.9.

- bump version to 6.0.9

Log : bump version to 6.0.9
@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: justforlxz

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sourcery-ai

sourcery-ai Bot commented May 15, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates Debian packaging metadata to bump the project version to 6.0.9.

File-Level Changes

Change Details Files
Bump Debian package version to 6.0.9 in the changelog.
  • Update the top entry in debian/changelog to reflect version 6.0.9.
  • Adjust associated metadata in the changelog entry (e.g., description or log line) to match the new version.
debian/changelog

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions

Copy link
Copy Markdown

TAG Bot

TAG: 6.0.9
EXISTED: no
DISTRIBUTION: unstable

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

你好!我是CodeGeeX。我已仔细审查了你提供的 git diff 内容。

本次修改主要针对 debian/changelog 文件,添加了新的版本条目以记录最近的代码变更。虽然 debian/changelog 是一种格式严格的打包文件,不涉及传统的编程逻辑、性能或安全漏洞,但在规范性和逻辑一致性上存在一些明显的问题。

以下是详细的审查意见:

1. 逻辑问题 - 版本号与描述自相矛盾

在新增的条目中,版本号被声明为 6.0.9,但在变更记录中却写着:
* chore: update version to 6.0.8

问题分析:这是一个明显的逻辑冲突。当前打包的版本是 6.0.9,但 changelog 却声称将版本更新到了 6.0.8。这通常是因为开发者在撰写 changelog 时复制了上一条的记录并修改了外层版本号,但遗漏了内部的描述。

改进建议:将 * chore: update version to 6.0.8 修改为 * chore: update version to 6.0.9,或者如果该条目仅仅是记录业务逻辑的修复,可以直接删除这一条 chore 记录。

2. 代码质量/规范性问题 - Debian Changelog 格式与规范

Debian 官方对 debian/changelog 的格式有严格的要求(通常由 debchangedch 工具生成)。

  • 时间戳格式异常:你的时间戳写的是 Fri, 15 May 2026 16:34:00 +0800
    • 问题:2026年5月15日是未来的时间。虽然在本地打包可能不会报错,但在某些严格的 CI/CD 环境或分布式构建系统中,未来时间会导致打包工具(如 dpkg-parsechangelog)抛出警告甚至错误。此外,Debian 的时间戳通常精确到秒,且必须遵循 RFC 2822 格式,建议使用 date -R 命令获取当前的真实时间。
  • 条目排序与合并
    • 问题:新增的 6.0.9 条目中包含了 fix(config)fix,而紧接着的 6.0.8 条目也是 fix: update window rules。通常,如果这些修复是连续进行的,且尚未正式发布 6.0.8,应该直接在 6.0.8 的条目下追加;如果 6.0.8 已经发布,则新建 6.0.9 是正确的,但应确保描述不重复。
  • 空格规范 -- justforlxz-- 前面严格规定必须是恰好一个空格(你的写法是正确的),但建议整个文件始终使用 dch 工具来维护,以避免人为引入空格或换行符错误。

3. 语法、性能与安全

  • 语法:Changelog 语法符合 Debian 规范,未发现格式破损。
  • 性能与安全:由于这是纯文本的版本记录文件,不涉及代码执行逻辑,因此无性能瓶颈或安全风险。

💡 改进后的代码建议

diff --git a/debian/changelog b/debian/changelog
index 2bbe3a9d1..9c399c283 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,11 @@
+dde-kwin (6.0.9) unstable; urgency=medium
+
+  * fix(config): add fullscreen area rule for dde-launcher
+  * chore: update version to 6.0.9
+  * fix: update window rules
+
+ -- justforlxz <justforlxz@gmail.com>  Wed, 24 May 2024 10:00:00 +0800
+
 dde-kwin (6.0.8) unstable; urgency=medium
 
   * fix: update window rules

(注:时间戳已修正为合理的过去时间,且修正了版本号描述的自相矛盾)

最佳实践提示:在维护 Debian 系列的包时,强烈建议使用 dch -i(自动增加版本号并打开编辑器)或 dch --append 等命令来修改 changelog,这样可以完全避免格式错误和时间戳不合规的问题。

@justforlxz
justforlxz requested a review from BLumia May 15, 2026 09:28
@justforlxz
justforlxz merged commit e1ebf03 into linuxdeepin:master May 18, 2026
20 checks passed
@deepin-bot

deepin-bot Bot commented May 18, 2026

Copy link
Copy Markdown
Contributor

TAG Bot

Tag created successfully

📋 Tag Details
  • Tag Name: 6.0.9
  • Tag SHA: 570c7810f1a23d8e3b131f98bd0b34484ddf7759
  • Commit SHA: 4229c3bddf93c68b2e9a6ee3e89398f89a5e7630
  • Tag Message:
    Release dde-kwin 6.0.9
    
    
  • Tagger:
    • Name: justforlxz
  • Distribution: unstable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants