Skip to content

fix(config): add fullscreen area rule for dde-launcher#390

Merged
justforlxz merged 1 commit into
linuxdeepin:masterfrom
MrQin-maker:master
May 15, 2026
Merged

fix(config): add fullscreen area rule for dde-launcher#390
justforlxz merged 1 commit into
linuxdeepin:masterfrom
MrQin-maker:master

Conversation

@MrQin-maker

@MrQin-maker MrQin-maker commented May 15, 2026

Copy link
Copy Markdown
Contributor

Add usefullscreenarea and usefullscreenarearule settings to ensure dde-launcher uses the correct fullscreen area.

为dde-launcher添加全屏区域规则配置,确保启动器正确使用全屏区域。

Log: 添加dde-launcher全屏区域规则
Influence: dde-launcher窗口将正确使用全屏区域显示,避免显示区域不正确的问题。

Summary by Sourcery

New Features:

  • Introduce usefullscreenarea and related fullscreen area rule settings for dde-launcher window behavior.

@deepin-ci-robot

Copy link
Copy Markdown

Hi @MrQin-maker. Thanks for your PR. 😃

@sourcery-ai

sourcery-ai Bot commented May 15, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds KWin window rule settings so that dde-launcher uses the correct fullscreen area, introducing usefullscreenarea and usefullscreenarearule entries in the window rules configuration.

File-Level Changes

Change Details Files
Configure KWin rules so dde-launcher respects the correct fullscreen area when displayed.
  • Add usefullscreenarea setting for the dde-launcher window rule so the launcher can opt into using the fullscreen workarea definition.
  • Add usefullscreenarearule setting to control how strictly the fullscreen area behavior is applied to dde-launcher.
  • Update or append the dde-launcher-specific rule block in the KWin rules configuration to include these new fullscreen-related options.
configures/kwinrulesrc

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot

Copy link
Copy Markdown

Hi @MrQin-maker. Thanks for your PR.

I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Add usefullscreenarea and usefullscreenarearule settings to
ensure dde-launcher uses the correct fullscreen area.

为dde-launcher添加全屏区域规则配置,确保启动器正确使用全屏区域。
PMS: BUG-355323
PMS: BUG-356919
Log: 添加dde-launcher全屏区域规则
Influence: dde-launcher窗口将正确使用全屏区域显示,避免显示区域不正确的问题。
@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: justforlxz, MrQin-maker

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@justforlxz
justforlxz merged commit bcf2519 into linuxdeepin:master May 15, 2026
11 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants