Skip to content

fix: add iio-sensor-proxy to short idle service config#1179

Merged
xionglinlin merged 1 commit into
linuxdeepin:masterfrom
xionglinlin:fix/370415
Jul 20, 2026
Merged

fix: add iio-sensor-proxy to short idle service config#1179
xionglinlin merged 1 commit into
linuxdeepin:masterfrom
xionglinlin:fix/370415

Conversation

@xionglinlin

@xionglinlin xionglinlin commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Added service configuration to ensure the system successfully enters "short-idle" mode after remaining idle for 5 minutes.

Influence:

  1. Test system entering and exiting short idle state
  2. Verify iio-sensor-proxy service remains active during idle
  3. Check sensor data availability during idle periods

fix: 在短空闲服务配置中添加 iio-sensor-proxy

新增服务配置,保证系统在静置5分钟后可以正常进入shortidle模式

Influence:

  1. 测试系统进入和退出短空闲状态
  2. 验证 iio-sensor-proxy 服务在空闲期间保持活跃
  3. 检查空闲期间传感器数据可用性

PMS: BUG-370415
Change-Id: Idc13850f8708e18036b4183d55f9de5463eb7543

Summary by Sourcery

Update power daemon configuration for short-idle behavior.

Enhancements:

  • Adjust power management configuration to ensure the system can enter short-idle mode after 5 minutes of inactivity.
  • Keep the iio-sensor-proxy service active during short-idle periods to maintain sensor data availability.

Added service configuration to ensure the system successfully enters "short-idle" mode after remaining idle for 5 minutes.

Influence:
1. Test system entering and exiting short idle state
2. Verify iio-sensor-proxy service remains active during idle
3. Check sensor data availability during idle periods

fix: 在短空闲服务配置中添加 iio-sensor-proxy

新增服务配置,保证系统在静置5分钟后可以正常进入shortidle模式

Influence:
1. 测试系统进入和退出短空闲状态
2. 验证 iio-sensor-proxy 服务在空闲期间保持活跃
3. 检查空闲期间传感器数据可用性

PMS: BUG-370415
Change-Id: Idc13850f8708e18036b4183d55f9de5463eb7543
@sourcery-ai

sourcery-ai Bot commented Jul 20, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the power daemon configuration so that the iio-sensor-proxy service is kept active during the 5‑minute short-idle state, ensuring sensor data remains available while the system is idle.

File-Level Changes

Change Details Files
Ensure iio-sensor-proxy remains active during short-idle by updating the power daemon JSON configuration.
  • Modify the short-idle service configuration block to include iio-sensor-proxy as an active service.
  • Adjust any related idle-state service lists or flags so short-idle transitions succeed with iio-sensor-proxy running.
  • Keep overall power policy and other service configurations unchanged aside from the short-idle updates.
misc/dsg-configs/org.deepin.dde.daemon.power.json

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

★ 总体评分:95分

■ 总体评价

代码正确添加了iio-sensor-proxy服务配置,逻辑清晰且无安全风险
配置文件更新符合需求,JSON语法正确,无扣分项

■ 详细分析

  • 1.语法逻辑(完全正确)✓

在misc/dsg-configs/org.deepin.dde.daemon.power.json文件的服务列表数组中,正确地在"fprintd.service"后添加了逗号,并新增了"iio-sensor-proxy.service"字符串,符合JSON数组语法规范。

无需修改

  • 2.代码质量(符合规范)✓

代码修改简洁明了,仅添加必要的服务配置项,没有多余的修改,符合配置文件维护规范。

无需修改

  • 3.代码性能(无性能问题)✓

仅增加一个静态配置项,对程序运行时的解析性能影响微乎其微,不涉及算法或循环逻辑。
建议:保持现状

  • 4.代码安全(存在0个安全漏洞)✓
    漏洞对比统计:新增漏洞 0 个,减少漏洞 0 个,持平 0 个
    总体风险描述:无安全风险,配置文件仅扩展服务列表,无外部输入交互、无命令执行、无权限操作。
  • 建议:无需修复,保持现有代码。

■ 改进建议代码示例

diff --git a/misc/dsg-configs/org.deepin.dde.daemon.power.json b/misc/dsg-configs/org.deepin.dde.daemon.power.json
index b46875291..9dd9dc330 100644
--- a/misc/dsg-configs/org.deepin.dde.daemon.power.json
+++ b/misc/dsg-configs/org.deepin.dde.daemon.power.json
@@ -826,7 +826,8 @@
                 "serial-getty@ttyAMA0.service",
                 "winbind.service",
                 "tpm2-abrmd.service",
-                "fprintd.service"
+                "fprintd.service",
+                "iio-sensor-proxy.service"
             ],
             "serial": 0,
             "flags": [

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mhduiy, xionglinlin

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xionglinlin
xionglinlin merged commit 598eb22 into linuxdeepin:master Jul 20, 2026
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants