feat(audio1): add AI noise reduction support#1172
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @MyLeeJiEun, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: MyLeeJiEun The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @MyLeeJiEun. Thanks for your PR. I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
23f2239 to
c5f2cf6
Compare
|
TAG Bot New tag: 6.1.100 |
9b30c86 to
f4a466d
Compare
|
/retest |
|
@MyLeeJiEun: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
|
@MyLeeJiEun: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
f4a466d to
36f2747
Compare
1. Add AiReduceNoise and AiNoiseSourcePath D-Bus properties for control center 2. Re-apply rnnoise when switching input device with AI noise enabled 3. Add write callback for AiReduceNoise to handle external property changes 4. Re-check AI noise state on PulseAudio context ready 5. Skip port check for virtual sources (rnnoise) 6. Add aiReduceNoiseEnabled DConfig entry Log: Add AI noise reduction feature with D-Bus properties, source switching, and DConfig support feat(audio1): 新增 AI 降噪功能 1. 新增 AiReduceNoise 和 AiNoiseSourcePath D-Bus 属性，供控制中心使用 2. AI 降噪开启时切换输入设备后重新应用 rnnoise 3. 添加 AiReduceNoise 写回调，处理外部属性变更 4. PulseAudio 上下文就绪时重新检查 AI 降噪状态 5. 虚拟声源（rnnoise）跳过端口检查 6. 添加 aiReduceNoiseEnabled DConfig 配置项 Log: 新增 AI 降噪功能，包括 D-Bus 属性、源切换处理和 DConfig 配置 PMS: STORY-41229
36f2747 to
bbb4391
Compare
| } | ||
| } | ||
| } | ||
| if strings.Contains(device, "rnnoise") { |
| return false | ||
| } | ||
|
|
||
| func (a *Audio) paDefaultSourceIs(target string) bool { |
There was a problem hiding this comment.
加一下注释，开启ai降噪的时候需要通过这种方式去获取当前的输入源
|
|
||
| logger.Infof("initAiReduceNoise: DConfig=%v, rnnoiseFound=%v, calling setAiReduceNoise(true)", | ||
| aiReduceNoiseEnabled, rnnoiseFound) | ||
| if err := a.setAiReduceNoise(true, ""); err != nil { |
There was a problem hiding this comment.
注释一下，传入空的时候使用默认的输入源作为开启降噪后的源
| } | ||
|
|
||
| s.setMute(GetConfigKeeper().Mute.MuteInput || !portConfig.Enabled) | ||
| s.setReduceNoise(a.ReduceNoise) |
There was a problem hiding this comment.
这是旧的降噪，是否需要移除了，还有下面的降噪的设置，放在这里更合适一点。
| } | ||
| // 如果 AI 降噪已开启，在切换输入设备后重新应用 rnnoise， | ||
| // 确保新选中的物理麦克风作为 rnnoise 的 master 源。 | ||
| a.PropsMu.RLock() |
There was a problem hiding this comment.
不要在这里做降噪，前面的物理通道会触发事件，但是可能还没得到响应，这是设置降噪，会扰乱事件的处理。在更新默认source的地方处理。
|
TAG Bot New tag: 6.1.101 |
4 participants
Log: Add AI noise reduction feature with D-Bus properties, DConfig persistence, and rnnoise virtual source handling
feat(audio1): 添加 AI 降噪功能支持
Log: 新增 AI 降噪功能，包含 D-Bus 属性、DConfig 持久化及 rnnoise 虚拟声源处理
PMS: STORY-41229