test(coop): add logic/coop/daemon/dt tests and expose HTTPFileClient - #763
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @pengfeixx, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
907bcec to
999f442
Compare
- Add logic tests: fileclient, fileserver, webproto, webbinder, tokencache, httpweb stub/fork - Add coop commandparser test; extend sharehelper and transferhelper_core tests - Add coop_gui discovercontroller, daemon searchlight/transferjob, dt setting/transfer tests - Fix stub.h memory leak with unique_ptr; replace sleep_for with promise sync - Use -fno-access-control instead of #define private public - 新增 logic 测试: fileclient、fileserver、webproto、webbinder、tokencache、httpweb stub/fork - 新增 coop commandparser 测试；扩展 sharehelper 与 transferhelper_core 测试 - 新增 coop_gui discovercontroller、daemon searchlight/transferjob、dt setting/transfer 测试 - 修复 stub.h 内存泄漏；用 promise 同步替换 sleep_for - 使用 -fno-access-control 替代 #define private public Log: 新增 coop/logic/daemon/dt 单元测试并修复测试质量问题 Influence: 提升业务模块单元测试覆盖率，不影响现有功能。
999f442 to
c618feb
Compare
deepin pr auto review★ 总体评分：95分■ 【总体评价】
■ 【详细分析】
■ 【改进建议代码示例】 // tests/logic/stub.h - addrof 函数改进，避免 UB
template<typename T>
char* addrof(T addr)
{
// 使用 memcpy 替代 union 类型转换，避免未定义行为
char* d;
std::memcpy(&d, &addr, sizeof(d));
return d;
}
// tests/logic/fileclient_test.cpp - 临时目录生成改进
void SetUp() override
{
// 使用 random_device 生成更安全的随机种子
std::random_device rd;
std::mt19937 gen(rd());
std::uniform_int_distribution<> dis(100000, 999999);
tmpDir = std::filesystem::temp_directory_path() / ("fc_test_" + std::to_string(dis(gen)));
std::filesystem::create_directories(tmpDir);
service = std::make_shared<NetUtil::Asio::Service>();
service->Start();
context = std::make_shared<NetUtil::Asio::SSLContext>(asio::ssl::context::tlsv12);
client = std::make_unique<FileClient>(service, context, "127.0.0.1", 12345);
} |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lzwind, pengfeixx The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/forcemerge |
|
This pr force merged! (status: unstable) |
3 participants
Add logic tests: fileclient, fileserver, webproto, webbinder, tokencache, httpweb stub/fork
Add coop commandparser test; extend sharehelper and transferhelper_core tests
Add coop_gui discovercontroller, daemon searchlight/transferjob, dt setting/transfer tests
Expose HTTPFileClient under ENABLE_UNIT_TEST for testability
新增 logic 测试: fileclient、fileserver、webproto、webbinder、tokencache、httpweb stub/fork
新增 coop commandparser 测试；扩展 sharehelper 与 transferhelper_core 测试
新增 coop_gui discovercontroller、daemon searchlight/transferjob、dt setting/transfer 测试
在 ENABLE_UNIT_TEST 下暴露 HTTPFileClient 以便测试
Log: 新增 coop/logic/daemon/dt 单元测试并暴露 HTTPFileClient
Influence: 提升业务模块单元测试覆盖率，不影响现有功能。