fix: keep wallpaper status row inside viewport#3357
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: svan71 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @svan71. Thanks for your PR. 😃 |
|
Hi @svan71. Thanks for your PR. I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
TAG Bot New tag: 6.1.101 |
930ae0e to
01e6f18
Compare
The fixed-size wallpaper preview inherited Layout.fillWidth from DccRowView, while the adjacent status DccGroupView has implicit width zero. The RowLayout then gave nearly all spare width to the preview and clipped the status text at the right edge. Stop the preview from consuming the fill allocation so the sibling status group keeps enough width to stay inside the viewport.
01e6f18 to
bfec0bc
Compare
2 participants
Summary
Prevent the fixed-size wallpaper preview from consuming the RowLayout fill allocation so the sibling status group retains enough width to render inside the viewport.
Root cause
DccRowView forwards Layout.fillWidth to its loader. The 197x110 preview item inherited fillWidth=true, while the adjacent DccGroupView has an implicit width of zero. The layout therefore assigned nearly all spare width to the preview and clipped the status text at the right edge.
Testing
This change contains no distribution theme or user-specific customization.