feat(accounts): replace passwd command with DBus SetPassword for pass…#3287
feat(accounts): replace passwd command with DBus SetPassword for pass…#3287qxp930712 wants to merge 1 commit into
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @qxp930712, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
…word modification
This commit replaces the direct invocation of the system passwd command
with the DBus SetPassword method for user password changes in the accounts
plugin. Key changes include:
1. Replaced QProcess-based passwd command execution with DBus
2. Added pre-flight password validation to check if new password and
repeat password match before attempting modification
3. Added password encryption step using cryptUserPassword before sending
to the backend service
4. Delegated old password authentication to polkit dialog instead of
piping plaintext credentials into the passwd process
5. Improved error reporting by forwarding DBus reply error messages
directly to the caller
The migration eliminates plaintext credential exposure in process
arguments and pipes, provides clearer error feedback, and integrates
properly with the system's polkit authentication framework.
Log: Improved password modification security and user experience
Influence:
1. Test password change flow for users with and without existing passwords
2. Verify polkit authentication dialog appears correctly during password change
3. Test mismatched password input validation
4. Verify error messages are displayed properly on failure
5. Test password modification in both GUI and non-GUI (needResult) modes
PMS:TASK-390539
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: qxp930712 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: qxp930712 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
TAG Bot New tag: 6.1.92 |
|
TAG Bot New tag: 6.1.93 |
|
TAG Bot New tag: 6.1.94 |
|
TAG Bot New tag: 6.1.95 |
|
TAG Bot New tag: 6.1.96 |
|
TAG Bot New tag: 6.1.97 |
|
TAG Bot New tag: 6.1.98 |
|
TAG Bot New tag: 6.1.99 |
|
TAG Bot New tag: 6.1.100 |
|
TAG Bot New tag: 6.1.101 |
3 participants
…word modification
This commit replaces the direct invocation of the system passwd command
with the DBus SetPassword method for user password changes in the accounts
plugin. Key changes include:
The migration eliminates plaintext credential exposure in process
arguments and pipes, provides clearer error feedback, and integrates
properly with the system's polkit authentication framework.
Log: Improved password modification security and user experience
Influence:
PMS:TASK-390539