Skip to content

chore: update changelog to 1:6.1.30#270

Merged
caixr23 merged 1 commit into
linuxdeepin:masterfrom
mhduiy:dev-changelog-1-6.1.30
Jun 17, 2026
Merged

chore: update changelog to 1:6.1.30#270
caixr23 merged 1 commit into
linuxdeepin:masterfrom
mhduiy:dev-changelog-1-6.1.30

Conversation

@mhduiy

@mhduiy mhduiy commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

更新说明

自动更新 changelog 到版本 1:6.1.30

变更内容

  • 更新 debian/changelog

版本信息

  • 新版本: 1:6.1.30
  • 目标分支: master

Summary by Sourcery

Chores:

  • Refresh debian/changelog entry for release 1:6.1.30.

@sourcery-ai

sourcery-ai Bot commented Jun 17, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the Debian changelog metadata to reflect the new package version 1:6.1.30 on the master branch.

File-Level Changes

Change Details Files
Align Debian packaging changelog with new package version 1:6.1.30
  • Increment the package version entry in the Debian changelog to 1:6.1.30
  • Ensure the latest changelog stanza reflects this version bump for the master branch release
debian/changelog

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions

github-actions Bot commented Jun 17, 2026

Copy link
Copy Markdown

TAG Bot

TAG: 6.1.30
EXISTED: no
DISTRIBUTION: unstable

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

update changelog to 1:6.1.30

Log: update changelog to 1:6.1.30
@mhduiy
mhduiy force-pushed the dev-changelog-1-6.1.30 branch from 7bf7a96 to 2f67fd1 Compare June 17, 2026 09:13
@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: caixr23, mhduiy

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@caixr23
caixr23 merged commit c446176 into linuxdeepin:master Jun 17, 2026
17 of 20 checks passed
@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

★ 总体评分:65分

■ 【总体评价】

代码仅更新了变更日志,完全缺失核心的主题圆角动态读取与监听修复逻辑
因缺失核心修复代码导致提交无效且无法解决既定BUG扣35分

■ 【详细分析】

  • 1.语法逻辑(存在严重错误)✕

diff仅包含debian/changelog的版本号升维和描述,未包含任何解决硬编码圆角问题的C++代码修改,属于无效提交
潜在问题:mainwindow.cpp中第208行的setRadius(8)iconbutton.cpp第15行的m_radius(8)以及constants.h第115行的int radius = 10等硬编码问题依旧存在,完全无法实现changelog中描述的"use application theme window radius and listen for changes"功能
建议:补充完整的代码修改,将硬编码替换为从DGuiApplicationHelper读取窗口圆角,并增加DApplicationHelper::instance()->themeTypeChanged信号的监听槽函数以实时更新

  • 2.代码质量(存在严重问题)✕

提交内容与变更日志描述严重不符,工程规范被破坏
潜在问题:代码审查无法基于此diff进行实质性验证,属于典型的“空提交”或“遗漏文件提交”错误
建议:确保提交的diff完整包含所有相关文件的修改,至少应包括mainwindow.cppitemwidget.cppiconbutton.cppconstants.h及其头文件

  • 3.代码性能(无性能问题)✓

由于未引入任何实际的业务逻辑代码,因此不存在性能损耗
建议:后续补充主题监听逻辑时,注意避免在频繁触发的绘制事件中进行重复的主题对象查询,应将圆角值缓存为成员变量并在信号触发时更新

  • 4.代码安全(存在0个安全漏洞)✓

漏洞对比统计:新增漏洞 0 个,减少漏洞 0 个,持平 0 个
本次diff仅修改了纯文本的changelog文件,未引入任何可执行代码或安全风险
建议:无

■ 【改进建议代码示例】

--- a/dde-clipboard/mainwindow.cpp
+++ b/dde-clipboard/mainwindow.cpp
@@ -22,6 +22,8 @@
 #include <DGuiApplicationHelper>
 #include <DApplicationHelper>
+#include <QSignalMapper>
+
 
 MainWindow::MainWindow(QWidget *parent)
     : DBlurEffectWidget(parent)
@@ -204,7 +206,14 @@ void MainWindow::initUI()
     m_clearButton->setFixedSize(60, 36);
     m_clearButton->setText(tr("Clear"));
     m_clearButton->setBackOpacity(200);
-    m_clearButton->setRadius(8);
+
+    auto updateClearButtonRadius = [this]() {
+        int radius = DGuiApplicationHelper::instance()->windowRadius();
+        m_clearButton->setRadius(radius);
+    };
+    updateClearButtonRadius();
+
+    connect(DApplicationHelper::instance(), &DApplicationHelper::themeTypeChanged, this, updateClearButtonRadius);
     m_clearButton->setVisible(false);
 
     m_searchEdit->setFixedWidth(240);

@deepin-bot

deepin-bot Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

TAG Bot

Tag created successfully

📋 Tag Details
  • Tag Name: 6.1.30
  • Tag SHA: 618a20be06833aa1c975a6063c2295590feb2573
  • Commit SHA: c4461762a5c84086b6170bdd7cbc2a8b560537be
  • Tag Message:
    Release dde-clipboard 6.1.30
    
    
  • Tagger:
    • Name: mhduiy
  • Distribution: unstable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants