perf(source-map): avoid temporary value reconstruction - #111
Merged
Merged
Conversation
Three changes eliminate unnecessary intermediate string and array allocations during source-map construction: 1. Inline code whitespace check: replace [...interior].some() spread with a charCodeAt loop — avoids allocating an array of characters. 2. Code segments validation: verify each span incrementally against value.slice() instead of rebuilding the full sourceValue string. 3. URL segments validation: track valueMatch boolean instead of concatenating decoded parts into a rebuilt URL string.
luojiyin1987
force-pushed
the
perf/avoid-temp-value-reconstruction
branch
from
September 7, 2026 04:11
ada64ea to
8ce5fe0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Eliminate explicitly constructed temporary strings and arrays during source-map validation.
Changes
Inline code whitespace check: replace
[...interior].some()spread with acharCodeAtloop — no character array allocation.Code segments validation (
code-segments.ts): addequalRange()— a directcharCodeAtcomparator that validates each span againstvaluewithout creating any substring. Replacesmd.slice() !== value.slice().URL segments validation: replace
node.url.slice(...)withnode.url.startsWith(output, valueOffset)— no substring per segment.What was removed
[...interior]arraysourceValuestring + N×md.slice+ N×value.sliceequalRange(char-by-char)valuestring +node.url.sliceper segmentstartsWith(no substring)Verification