Skip to content

perf(source-map): lazy-build sourceGapPrefix on first range query #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luojiyin1987 merged 1 commit into from
Sep 7, 2026
Merged

perf(source-map): lazy-build sourceGapPrefix on first range query #110

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 14 additions & 12 deletions src/source-map/build-source-map.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,7 @@ interface SegmentRangeOptions {
valueStart: number
valueEnd: number
emptyOffset?: number
sourceGapPrefix?: number[]
getSourceGapPrefix?: () => number[]
requireContiguousSource?: boolean
messages: RangeResolutionMessages
lineStarts: number[]
Expand Down Expand Up @@ -456,7 +456,7 @@ function resolveSegmentRange(options: SegmentRangeOptions): ParsedPosition {
segments,
valueStart,
valueEnd,
sourceGapPrefix,
getSourceGapPrefix,
requireContiguousSource,
messages,
lineStarts,
Expand All @@ -476,14 +476,10 @@ function resolveSegmentRange(options: SegmentRangeOptions): ParsedPosition {
const endSegmentIndex = findSegmentIndexAt(segments, valueEnd - 1);
if (startSegmentIndex === undefined || endSegmentIndex === undefined)
throw new RangeError(messages.incomplete);
if (
requireContiguousSource
&& (
!sourceGapPrefix
|| sourceGapPrefix[endSegmentIndex] !== sourceGapPrefix[startSegmentIndex]
)
) {
throw new RangeError(messages.nonContiguous);
if (requireContiguousSource && startSegmentIndex !== endSegmentIndex) {
const prefix = getSourceGapPrefix?.();
if (!prefix || prefix[endSegmentIndex] !== prefix[startSegmentIndex])
throw new RangeError(messages.nonContiguous);
}

const startSegment = segments[startSegmentIndex];
Expand Down Expand Up @@ -597,7 +593,6 @@ export const parseMdWithSourceMap = (md: string): ParsedMarkdownDocument => {
if (mappedSegments) {
if (hasStringField(node, 'value'))
originalValues.set(node, node.value);
sourceGapPrefixes.set(mappedSegments, buildSourceGapPrefix(mappedSegments));
}
if (
state.urlSegments.has(node)
Expand Down Expand Up @@ -714,7 +709,14 @@ export const parseMdWithSourceMap = (md: string): ParsedMarkdownDocument => {
valueStart,
valueEnd,
emptyOffset: state.emptyCodeOffsets.get(node as object),
sourceGapPrefix: sourceGapPrefixes.get(segs),
getSourceGapPrefix: () => {
let prefix = sourceGapPrefixes.get(segs);
if (!prefix) {
prefix = buildSourceGapPrefix(segs);
sourceGapPrefixes.set(segs, prefix);
}
return prefix;
},
requireContiguousSource: true,
messages: sourceRangeMessages,
lineStarts,
Expand Down