fix(multicluster): make service cleanup logic respect namespaces#15201
Open
cbond-cohere wants to merge 1 commit intolinkerd:mainfrom
Open
fix(multicluster): make service cleanup logic respect namespaces#15201cbond-cohere wants to merge 1 commit intolinkerd:mainfrom
cbond-cohere wants to merge 1 commit intolinkerd:mainfrom
Conversation
cbond-cohere
force-pushed
the
cleanup-namespaced-mirror-services
branch
3 times, most recently
from
7a4c271 to
df7b53f
Compare
maxbrunet
approved these changes
Apr 23, 2026
Contributor
maxbrunet
left a comment
maxbrunet
left a comment
There was a problem hiding this comment.
LGTM, thank you for debugging and fixing this!
unleashed
reviewed
Apr 24, 2026
cbond-cohere
force-pushed
the
cleanup-namespaced-mirror-services
branch
from
df7b53f to
8e84987
Compare
Member
|
It looks like there's a lint error where one of the test parameter can be removed. |
cbond-cohere
force-pushed
the
cleanup-namespaced-mirror-services
branch
from
8e84987 to
675055d
Compare
Author
Thanks @adleong! I ended up putting in an ignore directive for these warnings since other functions in the test suite ignore this particular check. Happy to remove the parameters altogether if you prefer. |
createOrUpdateHeadlessEndpoints and handleRemoteServiceUnexported compare a list of namespace-level endpoint mirror services to a cluster-wide list of services that match the headless mirror name. This results in unintended service deletion when multiple headless mirror services of the same name exist in different namespaces. Fix this by restricting the list call to the namespace of the exported service. Signed-off-by: Cody Bond <cody.bond@cohere.com>
cbond-cohere
force-pushed
the
cleanup-namespaced-mirror-services
branch
from
675055d to
61b1755
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
createOrUpdateHeadlessEndpoints and handleRemoteServiceUnexported compare a list of namespace-level endpoint mirror services to a cluster-wide list of services that match the headless mirror name. This results in unintended service deletion when multiple headless mirror services of the same name exist in different namespaces. Fix this by restricting the list call to the namespace of the exported service.
Fixes #15200