inject: add debug image annotations to ProxyAnnotations list#15197
inject: add debug image annotations to ProxyAnnotations list#15197mail2sudheerobbu-oss wants to merge 4 commits intolinkerd:mainfrom
Conversation
DebugImageAnnotation, DebugImageVersionAnnotation, and DebugImagePullPolicyAnnotation were missing from ProxyAnnotations. This caused namespace-level debug image annotations to not be inherited by pods (AppendNamespaceAnnotations only propagates annotations in the ProxyAnnotations list). Fixes linkerd#13636 Signed-off-by: Sudheer Obbu <mail2sudheerobbu@gmail.com>
|
Hi @linkerd/maintainers 👋 — first-time contributor here, happy to be working on Linkerd! This is a small focused fix for #13636: The fix is a 3-line addition to Happy to add a test or make any other changes if needed. Thanks for your time! 🙏 |
| k8s.DebugImageAnnotation, | ||
| k8s.DebugImageVersionAnnotation, | ||
| k8s.DebugImagePullPolicyAnnotation, |
There was a problem hiding this comment.
This is not correctly formatted, needs more indentation.
…tions The three DebugImage annotation entries were indented with a single tab, inconsistent with all other entries in the ProxyAnnotations slice which use double-tab indentation. Signed-off-by: Sudheer Obbu <mail2sudheerobbu@gmail.com>
|
Fixed! The three |
|
@unleashed — just a heads-up that the indentation issue you flagged is fixed in commit 70d4156. The three |
|
@unleashed — the indentation issue you flagged has been fixed in commit 70d4156. Could you take another look when you get a chance? Thank you! |
2 participants
DebugImageAnnotation, DebugImageVersionAnnotation, and DebugImagePullPolicyAnnotation were missing from ProxyAnnotations. This caused namespace-level debug image annotations to not be inherited by pods (AppendNamespaceAnnotations only propagates annotations in the ProxyAnnotations list).
Fixes #13636