feat: add gateway.healthCheckNodePort Helm value#15174
Merged
zaharidichev merged 1 commit intolinkerd:mainfrom Apr 28, 2026
Merged
feat: add gateway.healthCheckNodePort Helm value#15174zaharidichev merged 1 commit intolinkerd:mainfrom
zaharidichev merged 1 commit intolinkerd:mainfrom
Conversation
AldoFusterTurpin
force-pushed
the
aldo/feat/healthCheckNodePort
branch
2 times, most recently
from
1b3099e to
7d4d57e
Compare
AldoFusterTurpin
force-pushed
the
aldo/feat/healthCheckNodePort
branch
2 times, most recently
from
02ad44b to
905eeb7
Compare
|
Great, thanks for the proactivity! thanks folks 🙏🏽 |
Member
|
@AldoFusterTurpin lets get CI passing, you have some lint/fmt failures |
AldoFusterTurpin
force-pushed
the
aldo/feat/healthCheckNodePort
branch
from
221beaf to
f5bbd01
Compare
Contributor
Author
It was a small gofmt error from a unit test. It should be solved now. Thanks @zaharidichev! |
When externalTrafficPolicy is set to Local on the gateway service, Kubernetes auto-assigns a random healthCheckNodePort. This makes the port invisible, causes conflicts with other port controllers, and is inconsistent with the existing nodePort pinning support. Add an optional gateway.healthCheckNodePort value (and --gateway-healthcheck-nodeport CLI flag) following the same pattern as the existing gateway.nodePort and gateway.probe.nodePort. Fixes linkerd#15172 Signed-off-by: Aldo Fuster Turpin <aldo@timescale.com>
AldoFusterTurpin
force-pushed
the
aldo/feat/healthCheckNodePort
branch
from
f5bbd01 to
3c7b5dd
Compare
Contributor
Author
|
@zaharidichev CI is green. Thank you ! 🙂 |
Member
|
@AldoFusterTurpin can you edit the PR description to follow the commit guidelines so we can merge away |
Contributor
Author
@zaharidichev Done. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: add gateway.healthCheckNodePort Helm value
When externalTrafficPolicy is set to Local on the gateway service,
Kubernetes auto-assigns a random healthCheckNodePort. This makes
the port invisible, causes conflicts with other port controllers,
and is inconsistent with the existing nodePort pinning support.
Add an optional gateway.healthCheckNodePort value (and
--gateway-healthcheck-nodeport CLI flag) following the same
pattern as the existing gateway.nodePort and gateway.probe.nodePort.
Fixes #15172
Signed-off-by: Aldo Fuster Turpin aldo@timescale.com