Add Pushover.net support from LDAP sync#368
Open
Fmstrat wants to merge 1 commit intolinkedin:masterfrom
Open
Conversation
diegocepedaw
requested changes
Feb 25, 2022
| {{/isEqual}} | ||
| </li> | ||
| <li> Slack: <a>{{getUserInfo this @root.users 'contacts.slack'}}</a> </li> | ||
| <li> Pushover: <a>{{getUserInfo this @root.users 'contacts.pushover'}}</a> </li> |
Contributor
There was a problem hiding this comment.
most people will not be using pushover, it looks like this code will leave a bunch of empty pushover related ui elements, these should be made conditional on pushover data existing.
| name = name.decode("utf-8") | ||
| mobile = ldap_dict.get(LDAP_SETTINGS['attrs']['mobile']) | ||
| mail = ldap_dict.get(LDAP_SETTINGS['attrs']['mail']) | ||
| pushover = ldap_dict.get(LDAP_SETTINGS['attrs']['pushover']) |
Contributor
There was a problem hiding this comment.
this looks like it could potentially cause keyerror exceptions if there is no pushover data in ldap. The app should look and behave as it does now if there is no pushover data defined anywhere in ldap, iris, or oncall.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A PR will be submitted for Pushover.net support in Iris. This allows users to store a Pushover key in LDAP for use in this instance.