Open
Conversation
|
@Mythie is attempting to deploy a commit to the Crowdin Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
moduleType: "js"to thetransformhook return value so Rolldown knows.pofiles are being compiled to JS^8to thevitepeer dependency rangeProblem
Vite 8 switched to Rolldown which auto-detects module types by file extension.
.pofiles get assigned a non-JS module type, so when the plugin compiles them to ES modules, Rolldown chokes withTypeError: Cannot convert undefined or null to object.Fixes #2473
What changed
packages/vite-plugin/src/index.ts— addedmoduleType: "js"to transform return. This is a standard Rolldown/Vite 8 convention documented in the migration guide. Safely ignored by older Vite versions.packages/vite-plugin/package.json— peer depvitenow includes^8.Testing
All 9 existing tests pass. The
moduleTypeproperty is ignored by Vite 3-7 so this is backwards compatible.Also tested by patching https://github.com/documenso/documenso and running vite build over there when attempting the Vite@8 upgrade.