Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1924 +/- ##
==========================================
- Coverage 76.65% 76.11% -0.54%
==========================================
Files 81 85 +4
Lines 2090 2114 +24
Branches 533 539 +6
==========================================
+ Hits 1602 1609 +7
- Misses 375 393 +18
+ Partials 113 112 -1 ☔ View full report in Codecov by Sentry. |
aseerkt
commented
Apr 26, 2024
|
|
||
| if (parsedErrors.length) { | ||
| console.error("Error while parsing:") | ||
| throw parsedErrors |
Contributor
Author
There was a problem hiding this comment.
Not sure if throwing errors is the right approach. Should I simply log these errors and proceed with extraction?
Contributor
Author
Contributor
|
@JSteunou could you please take a look? |
Contributor
|
This would make stop at the 1st error. Is this the behavior we want? Just logging and throw? |
Contributor
Author
|
@andrii-bodnar I think we can close this PR in favor of #1925, since we are planning to deprecate |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Report errors from
parseandcompileTemplatein Vue Extractor.Types of changes
Fixes #1627
Checklist