feat(recommended): remove no-expression-in-message#113
Open
monholm wants to merge 1 commit intolingui:mainfrom
Open
feat(recommended): remove no-expression-in-message#113monholm wants to merge 1 commit intolingui:mainfrom
no-expression-in-message#113monholm wants to merge 1 commit intolingui:mainfrom
Conversation
Lingui v5 included placeholder values in PO comments, rendering this rule obsolete. BREAKING CHANGE: `no-expression-in-message` removed from recommended rules
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #113 +/- ##
=======================================
Coverage 97.86% 97.86%
=======================================
Files 11 11
Lines 563 563
Branches 191 191
=======================================
Hits 551 551
Misses 12 12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
@monholm thanks for your input. Lingui starting from 5.2 also supports named placeholderswhich should improve DX in that area. The eslint rule should also support this syntax and should not flag it. The general plan is to move towards explicitly named placeholders instead of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd like to open a discussion regarding whether the
no-expression-in-messagerule should be included in the recommended set of rules.Since lingui@v5 introduced support for placeholder value comments in the PO files, the rule seems obsolete. The rule is (for us at least) causing more friction than benefit, as we are forced to destructure objects for no other reason than to satisfy this rule, even though the context makes it clear what the translator should expect.
I ended up creating a PR instead of an issue to make it easier for the maintainers to merge this if they agree with the change, as it took more or less the same amount of effort as writing an issue and waiting for a response.
Let me know what you think and thank you for your work on the project :)