feat: no Plural inside Trans

[sjgeyer]

Rule to disallow nesting Plural components inside Trans components for improved localization.

Good:

<Plural value={count} one="You have # unread message" other="You have # unread messages" />

Bad:

<Trans>You have <Plural value={count} one="# unread message" other="# unread messages" /></Trans>

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.89%. Comparing base (073664e) to head (21ce4a1).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #110      +/-   ##
==========================================
+ Coverage   97.86%   97.89%   +0.02%     
==========================================
  Files          11       12       +1     
  Lines         563      571       +8     
  Branches      187      187              
==========================================
+ Hits          551      559       +8     
  Misses         12       12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[andrii-bodnar]

@sjgeyer looks good to me, thank you for the contribution!

[timofei-iatsenko]

Why you consider this bad? In my opinion the opposite is bad, nesting Plural inside Trans creates a perfectly fine ICU message without duplication:

You have {plural, count, one {# unread message} other {# unread messages}}

[sjgeyer]

it's less about the creation of the message than the quality of the translation. i've found that we get better and more reliable translations when the Plural includes the full sentence (or as much of the sentence as possible) vs. concatenating sentences inside a Trans

[timofei-iatsenko]

@sjgeyer could you add more details to the doc for that rule, like where to use tis rule and where not.

[andrii-bodnar]

Reminder: after releasing this, it would be great to mention this rule in the po-gettext formatter docs - https://lingui.dev/ref/catalog-formats#po-gettext

[andrii-bodnar]

Hi @sjgeyer, could you please address the comment above so that we can proceed with this PR? Thanks!

[sjgeyer]

@andrii-bodnar addressed! let me know if there needs to be any more clarification