Fix memory expiration logic due to timestamp format mismatch#5
Conversation
The `expires_at` column is stored as an RFC3339 string (with 'T' separator and timezone info) by the Go driver. SQLite's `datetime('now')` returns a string with space separator and no timezone offset (UTC).
Lexicographical comparison between these two formats was incorrect, causing expiring memories to persist indefinitely or expire prematurely depending on the context.
This commit wraps `expires_at` in SQLite's `datetime()` function in all queries to normalize the format before comparison, ensuring correct expiration logic.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
Fixes a bug where memory expiration logic was incorrect because of string format mismatches between Go's time serialization (RFC3339) and SQLite's
datetime('now')output.The fix involves wrapping the
expires_atcolumn indatetime()in all SQL queries to ensure both sides of the comparison are in the same format.Verified with a reproduction test case that confirmed the issue and the fix.
PR created automatically by Jules for task 11815751352958429024 started by @fakebizprez