Skip to content

Fix test harness mouse move.#1789

Merged
xStrom merged 1 commit intolinebender:mainfrom
xStrom:harness-move-bug
May 4, 2026
Merged

Fix test harness mouse move.#1789
xStrom merged 1 commit intolinebender:mainfrom
xStrom:harness-move-bug

Conversation

@xStrom
Copy link
Copy Markdown
Member

@xStrom xStrom commented May 3, 2026

The test harness uses widget.ctx().window_transform() which transforms from window space to content-box space. Doing border-box size division won't lead to correct results. It's better to take the center of the correct rect.

Fixes #1756

@xStrom xStrom added masonry Issues relating to the Masonry widget layer needs review Needs review before proceeding. labels May 3, 2026
Copy link
Copy Markdown
Contributor

@RagibHasin RagibHasin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@xStrom xStrom added this pull request to the merge queue May 4, 2026
@xStrom xStrom removed the needs review Needs review before proceeding. label May 4, 2026
Merged via the queue into linebender:main with commit 3e5dc47 May 4, 2026
17 checks passed
@xStrom xStrom deleted the harness-move-bug branch May 4, 2026 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

masonry Issues relating to the Masonry widget layer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clicking on a very small button fails in test harness

2 participants