Skip to content

Migrate all logical pixel Property values to Length.#1788

Draft
xStrom wants to merge 3 commits intolinebender:mainfrom
xStrom:props-length
Draft

Migrate all logical pixel Property values to Length.#1788
xStrom wants to merge 3 commits intolinebender:mainfrom
xStrom:props-length

Conversation

@xStrom
Copy link
Copy Markdown
Member

@xStrom xStrom commented May 3, 2026

This is a goal of the plan outlined in #1264, that properties should use Length for their logical pixel lengths. A bunch of properties use Length already and with this PR here all of them will.

Specifically, this PR changes the following:

Files Changed fields
masonry_core/src/properties/types/gradient.rs RadialGradientShape::FixedCircle
masonry_core/src/properties/border_width.rs BorderWidth::width
masonry_core/src/properties/box_shadow.rs BoxShadow::blur_radius
masonry_core/src/properties/corner_radius.rs CornerRadius::radius
masonry_core/src/properties/padding.rs Padding::left/right/top/bottom
masonry/src/properties/slider.rs TrackThickness / ThumbRadius

Additionally, all the constructors and call-sites were updated as well.


Draft because it depends on #1787 and currently includes all of those commits as well.

@xStrom xStrom added masonry Issues relating to the Masonry widget layer blocked Progress is blocked by some other task. labels May 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked Progress is blocked by some other task. masonry Issues relating to the Masonry widget layer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant