Conversation
taj-p
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #1601.
As was mentioned there, we seemingly cannot use indices to index the vector, otherwise it fails on Windows. Therefore, we changed it so the vector is first converted into an array. However, this now leads to issues on certain Mali GPUs (in this case tested on a Realme 8, but I saw other phones affected by this as well). A shader as the following:
unfortunately fails to compile for many phones:

First zero-initializing and then assigning each field seems to work fine:
Therefore, we need to use this approach as well to make it work on those phones.