Fix color emoji matching when emoji with non printing variation selector#617
Open
fundon wants to merge 1 commit intolinebender:mainfrom
Open
Fix color emoji matching when emoji with non printing variation selector#617fundon wants to merge 1 commit intolinebender:mainfrom
fundon wants to merge 1 commit intolinebender:mainfrom
Conversation
fundon
force-pushed
the
fix_emoji_with_vs16
branch
from
7f5a8ae to
00e09c1
Compare
fundon
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
fundon
force-pushed
the
fix_emoji_with_vs16
branch
2 times, most recently
from
dddb4c7 to
876646f
Compare
conor-93
requested changes
May 1, 2026
Contributor
conor-93
left a comment
conor-93
left a comment
There was a problem hiding this comment.
Thanks for the fix! I agree these variation selectors shouldn't affect font queries. I've got one comment about how the change is articulated.
fundon
changed the title
fundon
force-pushed
the
fix_emoji_with_vs16
branch
from
90bc1f2 to
f389309
Compare
|
By the way, there's also this project that @drott and I put together: https://github.com/google/emoji-segmenter It's used in Chrome. The ragel code can produce Rust output as well, if that's of interest. |
Contributor
Author
Interesting, thank you for sharing. I'll try. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS, after loading the system font, specifying a color emoji font for a range did not take effect.
Some special emoji will be followed by an invisible variation selector
\u{fe0f}.This causes the font query to not match correctly.
There are some emojis with non printing variation selector: