Optimize deinterleave() for AVX2#207
Merged
LaurenzV merged 2 commits intolinebender:mainfrom Apr 22, 2026
Merged
Conversation
Extract unzip256_intermediates helper to share per-input shuffle computation between unzip_low/unzip_high, then use it in handle_deinterleave to compute both results without redundant shuffles. This also deduplicates the two 256-bit arms in handle_unzip. Co-Authored-By: Claude <noreply@anthropic.com>
LaurenzV
approved these changes
Apr 21, 2026
Collaborator
LaurenzV
left a comment
LaurenzV
left a comment
There was a problem hiding this comment.
Thanks! To be honest I haven't thought this through completely as I'm not super knowledgeable in AVX SIMD, but I trust you and our pretty exhaustive tests all pass so looks good to me!
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #206
@LaurenzV noted that deinterleaving could be optimized the same way.
Emitting the proper shuffle is more involved than for zip, but it's already implemented in
handle_unzip(), so I've simply split it into a helper function and reused it.This code has good test coverage and all tests pass.