Fix bug that email notifier's value is not validated through APIs - #790
Merged
vincent-olivert-riera merged 2 commits intoSep 28, 2026
Merged
vincent-olivert-riera merged 2 commits into
vincent-olivert-riera merged 2 commits into
Conversation
We overlooked validating the email notifier's value during creation or updates via APIs. To fully resolve this issue, we have added validation at the model layer. As a result, the existing similar validation in admin.py is removed.
Previously, when a DjangoValidationError occurred, DRF would return a generic 500 Server Error response, which is not user-friendly. This kind of error should be shown in detail to user. Therefore, we have updated the DRF custom_exception_handler to convert DjangoValidationError into DRFValidationError. This change ensures that detailed messages are generated and returned to the user.
hoangpn
force-pushed
the
bug_fix/email_validation_for_notifier_APIs
branch
from
September 28, 2026 06:30
0b5c4e6 to
23f0343
Compare
vincent-olivert-riera
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We fixed a bug that email notifier's value is not validated through APIs by adding two updates: