Skip to content

Update documentation about Promgen permissions - #785

Merged
vincent-olivert-riera merged 4 commits into
line:masterfrom
hoangpn:docs/permissions
Sep 24, 2026
Merged

vincent-olivert-riera merged 4 commits into
line:masterfrom
hoangpn:docs/permissions

Conversation

@hoangpn

@hoangpn hoangpn commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

Several updates have been made to the Promgen permissions documentation to ensure it reflects the latest changes and enhancements in Promgen.

@vincent-olivert-riera vincent-olivert-riera left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. Just minor fixes.

Comment thread docs/user/permissions.rst Outdated

Service and Project permissions
-------------------------------
Any authenticated user can create **new Service** on Promgen. After creating a Service or Project,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Any authenticated user can create **new Service** on Promgen. After creating a Service or Project,
Any authenticated user can create a **new Service** on Promgen. After creating a Service or Project,

Comment thread docs/user/permissions.rst Outdated
- **Editor**: Can modify the Service or Project but cannot delete it or manage permissions.
- **Viewer**: Read-only access to the Service or Project.
- **Admin**: Has full control over the Service or Project, including managing permissions.
- **Editor**: Can modify the Service or Project content.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- **Editor**: Can modify the Service or Project content.
- **Editor**: Can modify the Service's or Project's contents.

Comment thread docs/user/permissions.rst Outdated
- User with **Service Admin** permission can manage all aspects of the Service, including its Projects and associated objects, but only the owner can delete the Service or any Project.
- User with **Project Admin** permission can manage the specific Project and its associated objects, but only the owner can delete the Service or any Project.
Project Admin of Project cannot also see or modify other Projects under the same Service. They cannot even view the parents Service's details unless they have explicit permissions on that Service.
Project Admin of Project cannot also see or modify other Projects under the same Service. They cannot even view the parents Service's details unless they have explicit permissions on that Service.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rewrite this to simplify it a little:

Suggested change
Project Admin of Project cannot also see or modify other Projects under the same Service. They cannot even view the parents Service's details unless they have explicit permissions on that Service.
Also, a Project Admin cannot see or modify other Projects under the same Service. They cannot even view the parent Service's details unless they have explicit permissions on that Service.

@hoangpn

hoangpn commented Sep 24, 2026

Copy link
Copy Markdown
Contributor Author

@vincent-olivert-riera
Thank you for your thorough review. I have made changes following your suggestions. 🙇

@vincent-olivert-riera

Copy link
Copy Markdown
Contributor

@hoangpn , please rebase this on master.

We have fixed a minor error in the documentation that caused a missing line break in the paragraph.
We have refined a section of text in the use cases within the Permissions documentation to
simplify it.
The user interface for Members has recently been updated. As a result, we have taken a new
screenshot of the updated UI and replaced the old one in the documentation to ensure it
remains current.
We have updated the documentation to offer a detail explanation of the Owner privileges in
Promgen, specifically at the Service and Project levels.

Additionally, the permissions matrix has been redesigned for adding Owner privileges.
@hoangpn

hoangpn commented Sep 24, 2026

Copy link
Copy Markdown
Contributor Author

@vincent-olivert-riera
Thank you. The PR was rebased. 🙇

@vincent-olivert-riera
vincent-olivert-riera merged commit dd5be9f into line:master Sep 24, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants