Skip to content

Add Custom Label explanation to Promgen docs - #784

Merged
vincent-olivert-riera merged 1 commit into
line:masterfrom
hoangpn:docs/custom_label
Sep 24, 2026
Merged

vincent-olivert-riera merged 1 commit into
line:masterfrom
hoangpn:docs/custom_label

Conversation

@hoangpn

@hoangpn hoangpn commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

Corresponding documentation for the Custom Label feature has been added to guide users on how to use it.

@vincent-olivert-riera vincent-olivert-riera left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done. Just two minor things to fix and we can merge this.

Comment thread docs/user/custom_labels.rst Outdated
Custom Labels
=============

Custom labels are a powerful feature that allows to add more labels to metric when Prometheus

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Custom labels are a powerful feature that allows to add more labels to metric when Prometheus
Custom labels are a powerful feature that allows to add more labels to metrics when Prometheus

Comment thread docs/user/custom_labels.rst Outdated
Custom labels are a powerful feature that allows to add more labels to metric when Prometheus
scrapes the targets.

By default, there is no custom labels. The Promgen's administrator can add custom labels to a

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
By default, there is no custom labels. The Promgen's administrator can add custom labels to a
By default, there are no custom labels. The Promgen's administrator can add custom labels to a

We have introduced a new feature called Custom Label. Corresponding documentation has been
added to guide users on how to use it.
@hoangpn

hoangpn commented Sep 24, 2026

Copy link
Copy Markdown
Contributor Author

@vincent-olivert-riera
Thank you for carefully review the PR. I have fixed them. Please continue reviewing it. 🙇

@vincent-olivert-riera
vincent-olivert-riera merged commit 0e40033 into line:master Sep 24, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants