feat(move): add received sharing destinations by doubleface · Pull Request #4208 · linagora/twake-drive

doubleface · 2026-09-17T13:00:04Z

Summary

Add received federated sharings as Move to destinations.
Preserve shared-drive context when validating or creating destination folders.
Cover writable and read-only destinations, cross-owner moves, and loading behavior.

coderabbitai · 2026-09-17T13:00:14Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 62b21a87-683d-496c-a136-b9e304e13df8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

bundlemon · 2026-09-17T13:04:17Z

BundleMon

Files updated (2)

Status	Path	Size	Limits
✅	intents/index.html	652B (-16B -2.4%)	-
✅	static/js/intents.(hash).js	16.87KB (-318B -1.81%)	-

Unchanged files (14)

Status	Path	Size	Limits
✅	static/resource/(hash).js	336.94KB	-
✅	static/js/main.(hash).js	58.45KB	-
✅	static/js/lib-react.(hash).js	43.8KB	-
✅	static/js/public.(hash).js	27.94KB	-
✅	static/js/lib-polyfill.(hash).js	22.37KB	-
✅	static/js/lib-router.(hash).js	21.86KB	-
✅	static/css/main.(hash).css	8.25KB	-
✅	manifest.webapp	6.06KB	-
✅	static/css/public.(hash).css	2.72KB	-
✅	services/qualificationMigration.js	2.45KB	-
✅	services/dacc.js	2.16KB	-
✅	index.html	824B	-
✅	public/index.html	744B	-
✅	assets/manifest.json	185B	-

Total files change -343B -0.06%

Groups updated (2)

Status	Path	Size	Limits
✅	*/.js	5.55MB (+440B +0.01%)	-
✅	*/.css	67.84KB (-64B -0.09%)	-

Unchanged groups (1)

Status	Path	Size	Limits
✅	*/.{png,svg,ico}	2.19MB	-

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

Handle MoveTo navigation and query refreshes for Shared Drive and Nextcloud sources. Keep the viewer open when the dialog is cancelled and leave it after a successful move. Add end-to-end coverage for moving a Shared Drive file from the viewer.

Expose the Sharing section in Move to and preserve federated sharing context for permission checks, folder creation, and confirmation.

Exercise file and folder moves into editor sharings and verify that viewer sharings remain unavailable as destinations.

Cover moves between federated shared drives and pending query state.\nRoute sharing setup through authenticated fixtures and page objects.\nKeep the file picker tabs aligned with their folder contents.\n\nValidated with the targeted Playwright suite (5 tests).

Public move contexts do not expose authenticated sharing paths, so the force calculation crashed before any move request was sent. Skip the shared-path lookup for public moves and cover the editable public-link flow with unit and end-to-end tests. Validated with the targeted MoveModal suite and the public-link Playwright scenario.

Cover the mobile MoveTo flow and total move failures with retry. Generalize the Playwright mobile project so every mobile spec runs on the device profile. Validated with the focused mobile suite and the desktop MoveTo, received-sharing, and Shared Drive scenarios.

codescene-delta-analysis

Gates Passed
3 Quality Gates Passed

See analysis details in CodeScene

Quality Gate Profile: The Bare Minimum
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.

zatteo · 2026-09-21T08:09:17Z

+    const addedItems = additionalItems.filter(
+      item =>
+        item?.dir_id === folderId &&
+        item.driveId === driveId &&


Why one item? and one item.?

Will remove unneeded optional chaining in new PR which will not come from a fork

zatteo · 2026-09-21T08:11:11Z

+        item?.dir_id === folderId &&
+        item.driveId === driveId &&
+        !sourceIds.has(item._id ?? item.id)
+    )


Why do we have two source for items?

One source is data coming from server and the other contains data created locally, waiting from server update (optimistic data). I will clarify this with a better naming

zatteo · 2026-09-21T08:15:17Z

Thanks for the multiple commits

zatteo · 2026-09-21T10:14:42Z

@doubleface why this PR is from a fork?

doubleface added the e2e Run the E2E suite on this PR label Sep 17, 2026

This comment was marked as outdated.

Sign in to view

doubleface force-pushed the fp-moveto-mysharings branch from 95f17ca to bb662f9 Compare September 17, 2026 14:22

This comment was marked as outdated.

Sign in to view

doubleface force-pushed the fp-moveto-sharings branch from 6c9e9c5 to ecfca55 Compare September 17, 2026 15:23

doubleface force-pushed the fp-moveto-sharings branch from ecfca55 to d4fe213 Compare September 17, 2026 15:24

This comment was marked as outdated.

Sign in to view

doubleface added 5 commits September 18, 2026 09:59

feat(move): Add received sharing destinations

b377b6b

Expose the Sharing section in Move to and preserve federated sharing context for permission checks, folder creation, and confirmation.

test(move): Cover received sharing destinations

05bc2f5

Exercise file and folder moves into editor sharings and verify that viewer sharings remain unavailable as destinations.

doubleface force-pushed the fp-moveto-mysharings branch from ccff8c3 to c446467 Compare September 18, 2026 07:59

codescene-delta-analysis Bot approved these changes Sep 18, 2026

View reviewed changes

doubleface marked this pull request as ready for review September 18, 2026 10:07

doubleface requested review from JF-Cozy, lethemanh, rezk2ll and zatteo as code owners September 18, 2026 10:07

zatteo reviewed Sep 21, 2026

View reviewed changes

doubleface force-pushed the fp-moveto-sharings branch 2 times, most recently from dcd6be6 to 17025a4 Compare September 21, 2026 10:24

doubleface deleted the branch linagora:fp-moveto-sharings September 21, 2026 12:46

doubleface closed this Sep 21, 2026

Navigation Menu

feat(move): add received sharing destinations - #4208

feat(move): add received sharing destinations#4208
doubleface wants to merge 6 commits into
linagora:fp-moveto-sharingsfrom
doubleface:fp-moveto-mysharings

doubleface commented Sep 17, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Sep 17, 2026 •

edited

Loading

Review skipped

Uh oh!

This comment was marked as outdated.

Uh oh!

bundlemon Bot commented Sep 17, 2026 •

edited

Loading

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

codescene-delta-analysis Bot left a comment

Uh oh!

zatteo Sep 21, 2026

Uh oh!

doubleface Sep 21, 2026

Uh oh!

zatteo Sep 21, 2026

Uh oh!

doubleface Sep 21, 2026

Uh oh!

zatteo commented Sep 21, 2026

Uh oh!

zatteo commented Sep 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

doubleface commented Sep 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

coderabbitai Bot commented Sep 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

This comment was marked as outdated.

Uh oh!

bundlemon Bot commented Sep 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

BundleMon

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

codescene-delta-analysis Bot left a comment

Choose a reason for hiding this comment

Uh oh!

zatteo Sep 21, 2026

Choose a reason for hiding this comment

Uh oh!

doubleface Sep 21, 2026

Choose a reason for hiding this comment

Uh oh!

zatteo Sep 21, 2026

Choose a reason for hiding this comment

Uh oh!

doubleface Sep 21, 2026

Choose a reason for hiding this comment

Uh oh!

zatteo commented Sep 21, 2026

Uh oh!

zatteo commented Sep 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

doubleface commented Sep 17, 2026 •

edited

Loading

coderabbitai Bot commented Sep 17, 2026 •

edited

Loading

bundlemon Bot commented Sep 17, 2026 •

edited

Loading