fix: client queryS being called without an id ( query options )

[rezk2ll]

what's changed

• added the getDriveSettingQuery for io.cozy.drive.settings queries
• used getDriveSettingQuery in saving sort choice
• fixed switch context view using rogue query ( without an id )

[zatteo]

I do not understand, when do we use io.cozy.files.settings and io.cozy.drive.settings?

[rezk2ll]

I do not understand, when do we use io.cozy.files.settings and io.cozy.drive.settings?

in ViewSwitcherContextProvider we use io.cozy.files.settings and in useFolderSort we use io.cozy.drive.settings.

i think it's best to mutualize them and use io.cozy.drive.settings, i think it's a great oppurtunity to do so since i started this refacto

[zatteo]

I do not understand, when do we use io.cozy.files.settings and io.cozy.drive.settings?

in ViewSwitcherContextProvider we use io.cozy.files.settings and in useFolderSort we use io.cozy.drive.settings.

i think it's best to mutualize them and use io.cozy.drive.settings, i think it's a great oppurtunity to do so since i started this refacto

Do we have two "Drive settings" doctype? I did not remember about io.cozy.files.settings

[rezk2ll]

I do not understand, when do we use io.cozy.files.settings and io.cozy.drive.settings?

in ViewSwitcherContextProvider we use io.cozy.files.settings and in useFolderSort we use io.cozy.drive.settings.
i think it's best to mutualize them and use io.cozy.drive.settings, i think it's a great oppurtunity to do so since i started this refacto

Do we have two "Drive settings" doctype? I did not remember about io.cozy.files.settings

As we discussed, the io.cozy.files.settings is the wrong way of storing the drive application-related settings, and it should live in io.cozy.{app}.settings

[bundlemon]

BundleMon

Files updated (2)

Status	Path	Size	Limits
✅	public/static/js/public.(hash).js	111.16KB (-12B -0.01%)	-
✅	static/js/main.(hash).js	147.52KB (-25B -0.02%)	-

Unchanged files (19)

Status	Path	Size	Limits
✅	static/js/(chunkId).(hash).js	958.28KB	-
✅	static/js/cozy.(hash).js	870.22KB	-
✅	public/static/js/(chunkId).(hash).js	870.09KB	-
✅	public/static/js/cozy.(hash).js	725.64KB	-
✅	(hash).js	336.11KB	-
✅	public/(hash).js	336.11KB	-
✅	services/qualificationMigration.js	283.49KB	-
✅	services/dacc.js	263.19KB	-
✅	public/static/js/lib-react.(hash).js	39.24KB	-
✅	static/js/lib-react.(hash).js	39.24KB	-
✅	public/static/css/cozy.(hash).css	33.38KB	-
✅	static/css/cozy.(hash).css	33.38KB	-
✅	public/static/js/lib-router.(hash).js	21.86KB	-
✅	static/js/lib-router.(hash).js	21.86KB	-
✅	static/css/main.(hash).css	16.77KB	-
✅	public/static/css/public.(hash).css	6.46KB	-
✅	manifest.webapp	3.04KB	-
✅	index.html	690B	-
✅	assets/manifest.json	185B	-

Total files change -37B 0%

Groups updated (1)

Status	Path	Size	Limits
✅	**/*.js	6.75MB (-37B 0%)	-

Unchanged groups (2)

Status	Path	Size	Limits
✅	**/*.{png,svg,ico}	2.17MB	-
✅	**/*.css	129.68KB	-

Final result: ✅

View report in BundleMon website ➡️

---

Current branch size history | Target branch size history

[shepilov]

@rezk2ll is it still relevant or close? do we now override this "choice" in the settings update?

[rezk2ll]

@rezk2ll is it still relevant or close? do we now override this "choice" in the settings update?

Hi it's still relevant and it's more of a refactoring chore in the drive . And it's needed for the requests performance.

In general we should never have requests without id