fix(lock): stop renewing a lease that cannot be extended - #4911
Merged
Merged
Conversation
MontaGhanmy
force-pushed
the
fix/lock-extend-lease
branch
from
September 11, 2026 10:23
2d9f85f to
d364f39
Compare
Return renewal failures from Extend and stop the renewer after logging its first failure. Keep the ownership-loss error internal. Cover ownership loss and Redis errors with deterministic virtual-time tests. Shutdown on Unlock is handled in a separate change.
shepilov
force-pushed
the
fix/lock-extend-lease
branch
from
September 17, 2026 07:47
d364f39 to
e549d73
Compare
shepilov
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
errLockLostfromExtend()instead of discarding the result. Log the first failed renewal and stop further renewal attempts.