Conversation
The modal-mode gate required canReshare (open_sharing flag) instead of checking actual write access, so a recipient with editor rights who shared a sub-folder they created still fell into the restricted SharingDetailsModal, which has no recipient list, link banner or Done button for non-drive documents.
FederatedFolderModal treated every non-root document inside a shared drive as read-only regardless of the current member's actual role, hiding the contact input and Done button even for an Editor sharing a folder they created themselves.
JF-Cozy
requested review from
doubleface,
rezk2ll and
zatteo
as code owners
September 17, 2026 13:54
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
zatteo
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ShareModal.jsx: the modal-mode gate now checkshasWriteAccessinstead ofcanReshare, so a recipient with editor rights lands on the editable modal instead of the restrictedSharingDetailsModal.FederatedFolderModal.jsx:isMemberReadOnlynow also checkshasWriteAccess, so nesting alone no longer hides the contact input and Done button for a recipient who has write access on the drive.Fixes linagora/twake-drive#4198.