Upgrade to rsbuild 2 - #3121
Upgrade to rsbuild 2#3121
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| }, | ||
| "devDependencies": { | ||
| "@rsbuild/core": "1.5.4", | ||
| "@rsbuild/core": "2.2.0", |
There was a problem hiding this comment.
Important update
We do not use our custom browserlist since we migrated to rsbuild which means we use default rsbuild values. They changed here.
From (rsbuild 1)
chrome >= 87
edge >= 88
firefox >= 78
safari >= 14
To (rsbuild 2)
chrome >= 107
edge >= 107
firefox >= 104
safari >= 16
Is it OK? What do we want to target? @Crash-- @JF-Cozy @doubleface @rezk2ll
There was a problem hiding this comment.
FYI:
- cozy-stack: no transpilation/polyfill
- cloudery: babel with browserslist-config-cozy
- sign up: Vite 7 default so Baseline Widely Available on 2025-05-01 (exactly same as rsbuild 2)
There was a problem hiding this comment.
sign up: Vite 7 default so Baseline Widely Available on 2025-05-01 (exactly same as rsbuild 2)
We fixed issue on safari 15 few days ago for signup... https://github.com/linagora/twake-workplace-private/issues/1535
There was a problem hiding this comment.
For the moment, please wait on that. I need to check the figures to define our current strategy of supported browsers.
There was a problem hiding this comment.
Seen together, for now, we stay on rsbuild 1.x defaults to avoid breaking changes
d6c9d05 to
9b3922b
Compare
It increase bundle size to force a chunk with every lib together especially for intent bundle. Because this chunk contains every cozy lib, it makes also little sense because it changes often. This changes was tested and validated in cozy-drive in github.com/cozy/cozy-drive/commit/8eb379f9127a381813f6ccc1c08368faa54470ea
9b3922b to
04c0461
Compare
BREAKING CHANGE: Update "@rsbuild/core": ">= 2.2.7" and add "core-js": ">= 3.50.0"
04c0461 to
484ab89
Compare
3 participants
Goal
=> support latest bundler features (RSC support, better ESM support, etc)
=> benefit from performance improvments (for dev and build env)
Benchmark
For twake-drive with
hyperfine --warmup 1 --runs 5 'yarn build'Before: 6,48s
After: 4,60s (-33%)