feat: Add menu to modify group permission

[zatteo]

Summary by CodeRabbit

• New Features
  • Group sharing permissions can now be changed directly, with immediate updates in the interface.
• Bug Fixes
  • Permission changes now show an error message if the update fails.
  • Failed group permission updates are rolled back safely to keep sharing state consistent.
• Refactor
  • Improved permission-change flow for both group and member recipients, with cleaner menu handling and fewer unnecessary updates.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6cb36b5a-87ca-4d3e-a70a-83471df0e117

📥 Commits

Reviewing files that changed from the base of the PR and between db82edd and 88b4a0f.

📒 Files selected for processing (5)

• packages/cozy-sharing/src/SharingProvider.jsx
• packages/cozy-sharing/src/SharingProvider.spec.jsx
• packages/cozy-sharing/src/components/Recipient/GroupRecipientPermissions.jsx
• packages/cozy-sharing/src/components/Recipient/MemberRecipientPermissions.jsx
• packages/cozy-sharing/src/components/Recipient/actions/permission.js

💤 Files with no reviewable changes (1)

• packages/cozy-sharing/src/components/Recipient/actions/permission.js

---

Walkthrough

This change adds an updateSharingGroupType method to SharingProvider, allowing group-level sharing permissions to be updated between read-only and read-write states with optimistic UI updates and rollback on failure. GroupRecipientPermissions is updated to use this new method along with an error alert, replacing its previous dependency on a removed permission action factory. MemberRecipientPermissions's setType handler is refactored to only trigger updates when the permission type actually changes. Corresponding tests are added for the new provider method.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the main change: adding a menu to modify group permissions in the share dialog.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/add-set-group-permission

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install failed. For unrecoverable errors, disable the tool in CodeRabbit configuration.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[JF-Cozy]

I think if (newType === type) part can be optimized (we hideMenu anyway, the only condition is to trigger the try/catch or no).

Besides, it seems to me we have a part of the action here, and in the makeActions part 🤔 it's not very clear. Do you think we can optimize a bit to gather action logic in only one place?

[zatteo]

I refactored it a bit to be simplier. What do you mean by we have a part of the action here, and in the makeActions part 🤔 ?

[zatteo]

I understand. Currently setReadOnlySharedPermission and setReadWriteSharedPermission are generic and are used to set permissions for members, groups and links. They only carry the UI of the action as you said.

[JF-Cozy]

is it ok to disptach something... and then if it doesn't work, we dispatch a rollback? 🤔 sounds strange...

[zatteo]

It is usual optimistic update? I took the logic from the update member logic for the optimistic update here.