Skip to content

only test user and group schema and resourcetype when they are enabled through the config#20

Merged
arietimmerman merged 1 commit into
limosa-io:mainfrom
Tlepel:user-and-groups-schema-and-resource
Oct 9, 2025
Merged

only test user and group schema and resourcetype when they are enabled through the config#20
arietimmerman merged 1 commit into
limosa-io:mainfrom
Tlepel:user-and-groups-schema-and-resource

Conversation

@Tlepel
Copy link
Copy Markdown
Contributor

@Tlepel Tlepel commented Oct 3, 2025

No description provided.

@arietimmerman arietimmerman requested a review from Copilot October 9, 2025 20:18
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds conditional testing based on configuration settings, ensuring that User and Group schema and resource type tests only run when the respective features are enabled in the configuration. This prevents test failures when certain SCIM resource types are disabled.

Key changes:

  • Wrap User schema and resource type tests in configuration checks
  • Wrap Group schema and resource type tests in configuration checks

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/schemas.js Added conditional checks for configuration?.users?.enabled and configuration?.groups?.enabled before testing User and Group schemas
src/resourcetypes.js Added conditional checks for configuration?.users?.enabled and configuration?.groups?.enabled before testing User and Group resource types

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@arietimmerman arietimmerman merged commit ff4dcb2 into limosa-io:main Oct 9, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants