Repository navigation
Report a proper error for an unknown model name - #101
Merged
Merged
Conversation
The --model option was validated with `identity`, which always
returns a truthy value for a non-empty string, so an invalid model
name slipped through to `case` in check-history and blew up with
a raw IllegalArgumentException ("No matching clause: ...") and
a stack trace.
The patch now validates the model name against the supported
models map and exits with status 1 instead of dumping a stack
trace.
Fixes #100
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The --model option was validated with
identity, which always returns a truthy value for a non-empty string, so an invalid model name slipped through tocasein check-history and blew up with a raw IllegalArgumentException ("No matching clause: ...") and a stack trace.The patch now validates the model name against the supported models map and exits with status 1 instead of dumping a stack trace.
Fixes #100