fix(deepseek): guard missing quant weight_block_size#261
Open
mesaleh wants to merge 1 commit into
Open
Conversation
Signed-off-by: Moustafa Saleh <moustafa.saleh@omniva.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getattr(..., "weight_block_size", None)before readingquant_config.weight_block_sizequant_block_size = 1behavior when the quant config does not expose that attributeMotivation
Some quantization config implementations do not define
weight_block_size. The current DeepSeek/Kimi loader path assumes the attribute exists before indexing it, which can fail during NVFP4 model loading.Validation
python3 -m compileall -q python/tokenspeed/runtime/models/deepseek_v3.py