Give us a self when reading a custom onion message#1809
Merged
TheBlueMatt merged 1 commit intolightningdevkit:mainfrom Oct 27, 2022
Merged
Give us a self when reading a custom onion message#1809TheBlueMatt merged 1 commit intolightningdevkit:mainfrom
TheBlueMatt merged 1 commit intolightningdevkit:mainfrom
Conversation
valentinewallace
force-pushed
the
2022-10-custom-om-self
branch
2 times, most recently
from
518dcc0 to
70566de
Compare
TheBlueMatt
reviewed
Oct 27, 2022
TheBlueMatt
reviewed
Oct 27, 2022
valentinewallace
force-pushed
the
2022-10-custom-om-self
branch
2 times, most recently
from
af59fc9 to
224a987
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1809 +/- ##
==========================================
- Coverage 90.72% 90.67% -0.06%
==========================================
Files 87 87
Lines 47364 47910 +546
Branches 47364 47910 +546
==========================================
+ Hits 42970 43441 +471
- Misses 4394 4469 +75 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
valentinewallace
force-pushed
the
2022-10-custom-om-self
branch
from
224a987 to
be5b548
Compare
jkczyz
reviewed
Oct 27, 2022
Contributor
jkczyz
left a comment
jkczyz
left a comment
There was a problem hiding this comment.
LGTM. Just a couple of nits.
valentinewallace
force-pushed
the
2022-10-custom-om-self
branch
from
be5b548 to
9eeee96
Compare
+ remove MaybeReadableArgs trait as it is now unused + remove onion_utils::DecodeInput as it would've now needed to be parameterized by the CustomOnionMessageHandler trait, and we'd like to avoid either implementing DecodeInput in messenger or having onion_utils depend on onion_message::* Co-authored-by: Matt Corallo <git@bluematt.me> Co-authored-by: Valentine Wallace <vwallace@protonmail.com>
valentinewallace
force-pushed
the
2022-10-custom-om-self
branch
from
9eeee96 to
150c87a
Compare
jkczyz
approved these changes
Oct 27, 2022
TheBlueMatt
approved these changes
Oct 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed for the bindings and gives a bit more flexibility for users as well