Retire cxx-common Docker build path - #781
Merged
Merged
Conversation
The root Dockerfile built remill via scripts/build.sh against cxx-common v0.6.0, which pins Intel XED v2022.04.17. lib/Arch/X86/Arch.cpp now references AVX-512 ISA-set enums that only exist in newer XED, so that build path fails to compile (issue #780). cxx-common is no longer supported. Remove the cxx-common Dockerfile and rename Dockerfile.llvm to Dockerfile so the only Docker build uses the dependencies/ superbuild, matching build.yml and the README (XED v2025.06.08). Delete the now-unused scripts/build.sh and scripts/travis.bat, and point docker-publish.yml at the renamed Dockerfile. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Ninja3047
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The root
Dockerfilebuilt remill viascripts/build.shagainst cxx-common v0.6.0, which pins Intel XED v2022.04.17.lib/Arch/X86/Arch.cppnow references AVX-512 ISA-set enums (XED_ISA_SET_AVX512_FP16_*,AVX512_FP8_CONVERT_*,AVX512_MEDIAX_*, etc.) that only exist in newer XED, so that build path fails to compile. cxx-common is no longer supported.Changes
Dockerfileand renameDockerfile.llvmtoDockerfile, so the only Docker build uses thedependencies/superbuild (XED v2025.06.08), matchingbuild.ymland the README.scripts/build.sh(only consumer of cxx-common v0.6.0) andscripts/travis.bat(dead cxx-common Windows references).docker-publish.ymlat the renamedDockerfile.Closes #780
🤖 Generated with Claude Code