Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds documentation for “Qualified Custodians” support in the stVaults docs, including an overview page and a Fireblocks step-by-step connection guide with screenshots.
Changes:
- Added a new “Qualified Custodians Supporting stVaults” overview page with a compatibility matrix.
- Added a Fireblocks user flow guide referencing new/existing screenshots under
static/img/.... - Linked the new custodian docs from the main stVaults documentation index (and removed one resource link from the “Essentials” list).
Reviewed changes
Copilot reviewed 3 out of 11 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
| static/img/stvaults/custodians/fireblocks/fb_1.png | Adds an additional screenshot used in the Fireblocks guide. |
| run-on-lido/stvaults/qualified-custodians/index.md | New overview page describing requirements + custodian compatibility matrix. |
| run-on-lido/stvaults/qualified-custodians/fireblocks.md | New Fireblocks connection walkthrough with images and links to related guides. |
| run-on-lido/stvaults/index.md | Adds a new section linking to the qualified custodian docs; adjusts “Essentials” links. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
Author
|
All Copilot comments have been covered |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please, go through these steps before you request a review:
📝 Describe your changes
🔎 Attach a source of truth or evidence that allows reviewers to confirm the changes independently