Skip to content

fix(management): reject non-object custom-model bodies #2408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ingwannu merged 1 commit into from
Aug 23, 2026
+26 −4
Merged

fix(management): reject non-object custom-model bodies #2408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/server/management/model-routes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,8 +394,10 @@ export async function handleModelRoutes(ctx: ManagementContext): Promise<Respons
}

if (url.pathname === "/api/custom-models" && req.method === "POST") {
let body: { provider?: unknown; modelId?: unknown; displayName?: unknown; contextWindow?: unknown; inputModalities?: unknown; reasoningEfforts?: unknown; defaultReasoningEffort?: unknown };
try { body = await readManagementJsonBody(req); } catch (error) { rethrowManagementBodyTooLarge(error); return jsonResponse({ error: "invalid JSON body" }, 400); }
let parsedBody: unknown;
try { parsedBody = await readManagementJsonBody(req); } catch (error) { rethrowManagementBodyTooLarge(error); return jsonResponse({ error: "invalid JSON body" }, 400); }
if (!isPlainRecord(parsedBody)) return jsonResponse({ error: "invalid JSON body" }, 400);
const body = parsedBody;
const provider = typeof body.provider === "string" ? body.provider.trim() : "";
const modelId = typeof body.modelId === "string" ? body.modelId.trim() : "";
if (!provider || !modelId) return jsonResponse({ error: "provider and modelId are required" }, 400);
Expand Down Expand Up @@ -441,8 +443,10 @@ export async function handleModelRoutes(ctx: ManagementContext): Promise<Respons
if (customPutMatch && req.method === "PUT") {
let id: string;
try { id = decodeURIComponent(customPutMatch[1]); } catch { return jsonResponse({ error: "invalid id encoding" }, 400); }
let body: { displayName?: unknown; contextWindow?: unknown; inputModalities?: unknown; modelId?: unknown; reasoningEfforts?: unknown; defaultReasoningEffort?: unknown };
try { body = await readManagementJsonBody(req); } catch (error) { rethrowManagementBodyTooLarge(error); return jsonResponse({ error: "invalid JSON body" }, 400); }
let parsedBody: unknown;
try { parsedBody = await readManagementJsonBody(req); } catch (error) { rethrowManagementBodyTooLarge(error); return jsonResponse({ error: "invalid JSON body" }, 400); }
if (!isPlainRecord(parsedBody)) return jsonResponse({ error: "invalid JSON body" }, 400);
const body = parsedBody;
const list = config.customModels ?? [];
const idx = list.findIndex(cm => cm.id === id);
if (idx === -1) return jsonResponse({ error: "not found" }, 404);
Expand Down
18 changes: 18 additions & 0 deletions tests/catalog-input-modality-enum.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,24 @@ describe("custom-model API rejects out-of-enum input modalities", () => {
});
}

test("POST and PUT reject non-object JSON bodies without persisting", async () => {
for (const body of [null, [], "model"]) {
persistCalls = 0;
const before = structuredClone(fixtureConfig.customModels);

const posted = await callCustomModels("POST", body);
expect(posted?.status).toBe(400);
expect(await posted!.json()).toEqual({ error: "invalid JSON body" });

const put = await callCustomModels("PUT", body, "/api/custom-models/existing-uuid");
expect(put?.status).toBe(400);
expect(await put!.json()).toEqual({ error: "invalid JSON body" });

expect(persistCalls).toBe(0);
expect(fixtureConfig.customModels).toEqual(before);
}
});

test("POST refuses a rejected modality with 400 instead of storing it", async () => {
persistCalls = 0;
const res = await callCustomModels("POST", {
Expand Down
Loading