More faithfully track SDL_GetColorKey semantics - #623
Merged
Merged
Conversation
SDL3_GetSurfaceColorKey starts by writing 0 to *key if non-NULL. SDL_GetColorKey only does so if the call will ultimately succeed. This patch leaves the value of *key untouched on failure paths.
Collaborator
|
Merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SDL3_GetSurfaceColorKey starts by writing 0 to *key if non-NULL. (see: https://github.com/libsdl-org/SDL/blob/main/src/video/SDL_surface.c#L703)
SDL_GetColorKey only does so if the call will ultimately succeed. (see: https://github.com/libsdl-org/SDL/blob/release-2.32.x/src/video/SDL_surface.c#L392)
This patch updates the sdl2-compat implementation to leaves the value of *key untouched on failure paths. This fixes issue #621 in UQM 0.8 where the flashrect does not function properly.