ci: the platforms the makefile already supports - #151
Open
WizzardSK wants to merge 2 commits into
Open
Conversation
Nine targets that Makefile.libretro has had all along and the CI never built: Windows 32-bit, MacOS x64, iOS arm64, iOS 9, tvOS, 3DS, WiiU, Switch and Vita. Each resolves to the target name its template expects - dosbox_libretro_ios.dylib, _tvos.dylib, _ctr.a, _wiiu.a, _libnx.a, _vita.a - so what was missing was the job rather than any support for the platform.
GameCube, Wii, PSP, PS3 and Emscripten, on the same footing as the rest: the makefile already knows ngc, wii, psp1, psl1ght and emscripten, and each resolves to the archive name its template expects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fourteen targets that
Makefile.libretrohas supported all along and the CI never built: Windows 32-bit, MacOS x64, iOS arm64, iOS 9, tvOS, 3DS, WiiU, Switch, Vita, GameCube, Wii, PSP, PS3 and Emscripten.Nothing here teaches the core a new platform. Every one of these already has a branch in the makefile, and each resolves to the file name its template expects:
So the jobs are plain. Two carry a variable: Windows 32-bit needs
platform: winandWITH_DYNAREC: x86, for the same reason the existing x64 job does — the makefile knowswinrather thanwin32and cannot guess a dynarec when cross compiled from Linux.Everything from 3DS down runs the interpreter. This fork's dynarec backends are armv4le, x86, x86_64 and mipsel, and none of those platforms is one of them — the same note the aarch64 job already carries. For a core this small that is not much of a loss, and an interpreter build is still a core where there was none.
What is checked and what is not. The makefile parses and resolves correctly for all fourteen, which is what can be established without the hardware. Whether each one links is for the buildbot to say. I would rather send them together and drop whichever fail than add them one a week: none is load-bearing for the platforms that build today, so a failure costs a line of YAML.
genode,ps3andqnxare left out — no template for the first and last, andps3ispsl1ghtunder another name.