Repository navigation
Conversation
Owner
|
@eryajf thanks for this PR. Before it can be reviewed and merged, every commit needs to be signed. GitHub shows these as unsigned: f0365f0. Please sign them (GPG or SSH, with the key added to your GitHub account as a signing key), then force-push. GitHub's guide: https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits |
Owner
|
Thanks @eryajf. #352 makes the same fix: an Edit menu, so ⌘Z ⇧⌘Z ⌘X ⌘C ⌘V ⌘A reach the window's text fields. It was opened first and fixes #340, so I'm closing this one in favour of it. Your |
4 of 6 tasks
sundarshahi
added a commit
to sundarshahi/kiri
that referenced
this pull request
Nov 17, 2026
The window sets user-select: none on body, and .gfind input didn't turn it back on. Credit to @eryajf, who spotted it in libracoder#397.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes and why
The top search field now preserves native text editing on all platforms and macOS exposes the standard Edit menu actions through the focused WKWebView.
⌘Aselects the whole query,⌘⌫clears it, and⌘Zrestores the cleared value. The new native menu labels are translated for all 37 shipped languages, and the language tests now catch missing native menu translations.No related issue: GitHub Issues are disabled on the fork, and the upstream issue search found no matching search-field issue.
How you tested it
Pre-fix search-field keyboard shortcuts:
Post-fix search-field keyboard shortcuts:
Tested on: macOS 26.4. The automated UI suite also covers the macOS, Windows and Linux page variants.
How you found it
AI tools used to write this change: yes — code investigation, implementation, test updates and PR preparation.
Checklist
cargo fmt,cargo clippyand the tests passcargo fmt --checkstill reports pre-existing formatting differences inlang.rs, andcargo clippywas not run. The Rust and UI test commands above pass.